HCAL: fixing pulse containment correction algorithm for Run3 trigger primitives

[TaeunKwon]

PR description:

This PR is the follow-up of the previous PR #34572, to switch on the functionality of fixing Pulse containment correction algorithm for the trigger primitive energy reconstruction using PFA1' scheme in Run3 condition. The configurable parameter, applyFixPCC is only turned on in Run 3 condition by run3_common modifier, and apply the fix described in #34572. The impact by this PR is presented in the presentation. The agreement between the Trigger Primitive energy for PFA1' and the RecHit energy for MAHI in high energy is achieved by this change in Run3 MC.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport. It can be backported to 11_3_X after this PR is revised and merged.

[abdoulline]

@TaeunKwon could you, please edit the PR title to make it more meaningful/explcit/self-explanatory, e.g.
"HCAL: fixing pulse containment correction algorithm for Run3 trigger primitives"

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34805/24530

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @TaeunKwon for master.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (l1, alca)
• CalibCalorimetry/HcalTPGEventSetup (l1, alca)
• SimCalorimetry/HcalTrigPrimProducers (l1)

@malbouis, @yuanchao, @cmsbuild, @rekovic, @tlampen, @pohsun, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @abdoulline, @rovere, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[TaeunKwon]

@TaeunKwon could you, please edit the PR title to make it more meaningful/explcit/self-explanatory, e.g.
"HCAL: fixing pulse containment correction algorithm for Run3 trigger primitives"

I'm so sorry, I forgot to paste the title before submitting the PR.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c571ac/17590/summary.html
COMMIT: e97ecfb
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34805/17590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 1260
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998128
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 4 / 38 workflows

[tvami]

+alca

• code changes are in line with the PR description
• Comparison plots show differences in the expected quantities

[qliphy]

kindly ping @cms-sw/l1-l2

[abdoulline]

@cms-sw/l1-l2
please, approve. This PR stays idle for 22 days...

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test
(to refresh them)

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c571ac/18197/summary.html
COMMIT: e97ecfb
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34805/18197/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 1328
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999054
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 4 / 38 workflows

[perrotta]

+1