initialize Trackster::iterationIndex_

[slava77]

in an unrelated PR tests I noticed that the iterationIndex is changing randomly
e.g. #34852 (comment)

The proposal is to initialize to 0, but since it's a valid iteration value, I'm not so sure.
@cms-sw/hgcal-dpg-l2 please confirm if this is OK.
Thank you.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34858/24656

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

• DataFormats/HGCalReco (upgrade, reconstruction)

@perrotta, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24f1a4/17747/summary.html
COMMIT: 8c588de
CMSSW: CMSSW_12_1_X_2021-08-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34858/17747/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @ggovi o2o tools fixes and improvements for python3 #34848
• @cms-tau-pog Enable boosted tau reco to run at miniAOD #34576
• @AdrianoDee Adding LUT approach for PackedCandidates #34446
• @jeongeun Migrate module configuration in RecoPixelVertexing to use default cfipython #34817
• @jeongeun Migrate module configuration in RecoVertex to use default cfipython #34818
• @iarspider [GCC11] Fix "this pointer is null" in class FWRecoGeometryESProducer of Fireworks/Geometry #34824
• @iarspider [GCC11] Add missing #include for std::size_t definition #34825

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24f1a4/17747/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24f1a4/17747/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2999391
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34858 8c588de

• this should remove now somewhat frequent random differences in ticlIteration plots
• related to the value, if a better choice than 0 is found, it can be updated later
• jenkins tests pass and comparisons with the baseline show differences in ticlIteration plots (somewhat as expected).

[perrotta]

+1

• @srimanob , this may help remove random differences in ticlIteration outputs: let try to merge it and see its effects on the IBs
• As Slava says, if a better choice than 0 is found for the initialization value, it can be updated later

[perrotta]

merge

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.