Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Make HLT addOnTest GEN step to use 1 concurrent LuminosityBlock #35350

Conversation

makortel
Copy link
Contributor

PR description:

Tests of #35326 (comment) pointed out that the GEN(+others) step of the HLT addOnTests use Pythia8GeneratorFilter while using multiple threads and therefore also 2 concurrent lumis by default. The generator fragment uses Tauola, so Pythia8ConcurrentHadronizerFilter can not be used. This PR suggests to explicitly use 1 concurrent lumi in the GEN step.

If Tauola is not strictly needed, an alternative would be to change the GEN fragment to TTbar_8TeV_TuneCUETP8M1_cfi / TTbar_13TeV_TuneCUETP8M1_cfi that use Pythia8ConcurrentHadronizerFilter.

PR validation:

In a private test with #35326 the addOnTests run to completion.

They use Pythia8 with Tauola, so trivial concurrency options are out
of the table and just running it with 1 concurrent lumi is simpler.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35350/25415

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • Configuration/HLT (hlt)

@Martin-Grunewald, @missirol, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

If Tauola is not strictly needed, an alternative would be to change the GEN fragment to TTbar_8TeV_TuneCUETP8M1_cfi / TTbar_13TeV_TuneCUETP8M1_cfi that use Pythia8ConcurrentHadronizerFilter.

I would think that Tauola is not really necessary in this case, so we could just change the fragment. Let's see what Martin suggests.

@Martin-Grunewald
Copy link
Contributor

Indeed, TTbar_13TeV_TuneCUETP8M1_cfi should be just fine.

@makortel
Copy link
Contributor Author

Thanks, I'll prepare another PR that uses the non-Tauola TTbar GEN fragments.

@makortel
Copy link
Contributor Author

Done in #35358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants