Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-Tauola GEN fragments in HLT addOnTest #35358

Merged
merged 1 commit into from Sep 22, 2021

Conversation

makortel
Copy link
Contributor

PR description:

Tests of #35326 (comment) pointed out that the GEN(+others) step of the HLT addOnTests use Pythia8GeneratorFilter while using multiple threads and therefore also 2 concurrent lumis by default. The generator fragment uses Tauola, so Pythia8ConcurrentHadronizerFilter can not be used. Following comments in #35350 (comment) this PR suggests to change the GEN fragments to those without Tauola so Pythia8ConcurrentHadronizerFilter, that supports concurrent lumis, can be used.

PR validation:

In a private test with #35326 the addOnTests run to completion.

The non-Tauola TTbar GEN fragments use
Pythia8ConcurrentGeneratorFilter that is compatible with concurrent
lumis.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35358/25427

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • Configuration/HLT (hlt)

@Martin-Grunewald, @missirol, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bee7ee/18797/summary.html
COMMIT: cfb3f35
CMSSW: CMSSW_12_1_X_2021-09-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35358/18797/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 22, 2021

+1

@cmsbuild cmsbuild merged commit d4178d7 into cms-sw:master Sep 22, 2021
@makortel makortel deleted the addOnTestHLTGENDropTauola branch September 22, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants