FastSim removal of unused package FastSimulation/EventProducer

[sbein]

PR description:

Removing FastSimulation/EventProducer

which contains the FamosProducer.cc and FamosManager.cc ED scripts. They are not used in sample production, and there are currently no other known uses. This is a resolution to the issue:

#35243

One spurious reference to the Famos producers is also made in
FastSimulation/ForwardDetectors/test/CastorTowerProducerTest_cfg.py

This does not seem to be usable anymore and the authors of the code left the experiment long ago, and so was also removed.

PR validation:

only unused code is removed, so no changes are "theoretically" possible. A standard recipe from runTheMatrix, 135.1, was tested locally without any apparent issue.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35352/25417

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @sbein (Sam Bein) for master.

It involves the following packages:

• FastSimulation/EventProducer (fastsim)
• FastSimulation/ForwardDetectors (fastsim)

@civanch, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[makortel]

@smuzaffar Since the entire package FastSimulation/EventProducer is removed here, should the PR also remove its entry from

cmssw/Utilities/ReleaseScripts/scripts/CMSSWReleaseDependency.rules

Line 32 in b493773

FastSimulation/EventProducer/.* : geant4.*

?

[smuzaffar]

@makortel , that cleanup can be performed in a separate PR

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a160c6/18785/summary.html
COMMIT: 8029159
CMSSW: CMSSW_12_1_X_2021-09-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35352/18785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[sbein]

I'm happy to just go ahead and modify cmssw/Utilities/ReleaseScripts/scripts/CMSSWReleaseDependency.rules

here so it's done. Opposition? @smuzaffar @makortel

[smuzaffar]

as no one has sign this PR yet, so go ahead and update CMSSWReleaseDependency.rules ( just drop the FastSimulation/EventProducer/.* : geant4.* line)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35352/25426

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35352 was updated. @smuzaffar, @civanch, @Dr15Jones, @lveldere, @makortel, @ssekmen, @mdhildreth, @cmsbuild, @sbein can you please check and sign again.

[sbein]

+1

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a160c6/18796/summary.html
COMMIT: eaae714
CMSSW: CMSSW_12_1_X_2021-09-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35352/18796/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1