Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[120X] Include new ideal beamspot records in Run-3 MC design GT #35515

Merged
merged 1 commit into from Oct 5, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Oct 3, 2021

New 2021 design MC beamspot GT

Backport of the beamspot part of [1]
This PR is to include a new record introduced in [2] in the 2021 design MC as it was realized earlier that it was not created, see the comment [3]. The HN request can be found under [4].

The new GT and the diff wrt to the prev versioned GT are

They differ only in the requested tags:

  | BeamSpotOnlineHLTObjectsRcd | - | - | BeamSpotOnlineObjects_Ideal_Centered_SLHC_v3_mc
  | BeamSpotOnlineLegacyObjectsRcd | - | - | BeamSpotOnlineObjects_Ideal_Centered_SLHC_v3_mc

[1] #35514
[2] #35373
[3] #35478 (comment)
[4] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4474/3.html

if this PR is a backport please specify the original PR and why you need to backport that PR:

Partial backport of #35514

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Oct 3, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

test parameters:

  • workflows = 12034.0

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@cmsbuild , please test

@tvami tvami changed the title Include new ideal beamspot records in Run-3 MC design GT [120X] Include new ideal beamspot records in Run-3 MC design GT Oct 3, 2021
@cmsbuild cmsbuild added backport and removed backport labels Oct 3, 2021
@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

 cmsbuild added tests-started and removed tests-pending labels 15 hours ago

@smuzaffar are the tests stuck?

@smuzaffar
Copy link
Contributor

please test
no idea why the previous test did not start

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e93f2c/19348/summary.html
COMMIT: 8188603
CMSSW: CMSSW_12_0_X_2021-10-03-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35515/19348/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e93f2c/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998524
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2021

+1

  • Update with the missing ideal beamspot records the Run-3 MC design GT in autoCond
  • No effect on real data GTs

@cmsbuild cmsbuild merged commit 58e4ac5 into cms-sw:CMSSW_12_0_X Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants