Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common alignment algorithm consumes migration #35861

Merged
merged 5 commits into from Oct 29, 2021

Conversation

bbilin
Copy link
Contributor

@bbilin bbilin commented Oct 27, 2021

PR description:

This PR completes the consumes migration of Alignment/CommonAlignmentAlgorithm package. Resolves cms-AlCaDB/AlCaTools#44

PR validation:

WF 1001.0 ran successfully.

1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5+ALCAHARVD7 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED Step5-PASSED Step6-PASSED Step7-PASSED Step8-PASSED Step9-PASSED - time date Wed Oct 27 13:41:09 2021-date Wed Oct 27 13:32:12 2021; exit: 0 0 0 0 0 0 0 0 0 0
1 1 1 1 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport, no backport is needed.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35861/26240

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bbilin (Bugra Bilin) for master.

It involves the following packages:

  • Alignment/CommonAlignmentAlgorithm (alca)
  • Alignment/CommonAlignmentProducer (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

@cmsbuild , please test

@bbilin bbilin changed the title Common alignment algorithm consumes mig Common alignment algorithm consumes migration Oct 27, 2021
@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

@cmsbuild , please abort

@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

test parameters:

  • addpkg = Alignment/TrackerAlignment

@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

@cmsbuild , please abort

@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

test parameters:

  • addpkg = Alignment/TrackerAlignment
  • workflows = 1001.0

@tvami
Copy link
Contributor

tvami commented Oct 27, 2021

@cmsbuild , please test

@bbilin
Copy link
Contributor Author

bbilin commented Oct 28, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35861/26267

@cmsbuild
Copy link
Contributor

Pull request #35861 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Oct 28, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bedcf/20002/summary.html
COMMIT: 8d98c36
CMSSW: CMSSW_12_1_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35861/20002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Oct 28, 2021

+alca

  • tests pass
  • code changes in line w/ the PR description

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_12_1_X, CMSSW_12_2_X Oct 29, 2021
@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated ES get functions in Alignment/CommonAlignmentAlgorithm
7 participants