Delete obsolete calls to "isDuplicateLCT" in the L1T CSC DQM

[dildick]

PR description:

Delete obsolete calls to isDuplicateLCT() function in the L1T CSC DQM since PR #34245 was merged.

An upgrade that we had planned for Phase-2, i.e. increasing the number of CLCTs/LCTs 
that are read out, was rolled back. This is not in the firmware for Run-3. We only read out the first two CLCTs/LCTs.

PR validation:

Tested with ME2/1 B904 data from a data run two weeks ago. Results for CLCTs and LCTs look good. About 0.63% CLCTs too many in emulator for ME2/1.

There is an issue with ME2/1 CLCTs with quality == 7 in the data. First reported here: http://cmsonline.cern.ch/cms-elog/1127545. Those CLCTs are invalid. The issue persists in most recent B904 tests. It concerns 6 in ~10k CLCTs.

CSC_dataVsEmul_B904_Cosmic_Run_211105_132717.pdf

I also re-analyzed the data run with 115k events from this July 1st 2021 with the ME1/1 B904 test stand. I notice that the CLCT bending, slope and Run-2 pattern number do not match at all between data and emulation. In my analysis for PR #34417 several months ago with an older version of the unpacker I did not see this. The agreement was much better. The disagreement is not seen for LCT bending, slope and Run-2 pattern number. Perhaps it's an issue with the unpacker for ME1/1.

CSC_dataVsEmul_B904_Cosmic_Run_210701_135109.pdf

This PR does not intend to fix the issues mentioned above.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@giovanni-mocellin @tahuang1991

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36156/26706

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-927c14/20594/summary.html
COMMIT: 2a7f065
CMSSW: CMSSW_12_2_X_2021-11-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36156/20594/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3327156
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3327128
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[dildick]

5 failures from messagelogger

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• @dildick I assume that the issues with data that you are mentioning in the PR description have been already propagated in the due forums: otherwise please do!

[dildick]

Yes, these things are discussed in GEM-CSC trigger meetings. I mention it again for completeness.