Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ak5 to ak4 transition #3631

Merged

Conversation

rappoccio
Copy link
Contributor

Merging updates from AK5->AK4 transition to the main branch, on top of 710pre7. Also updated to main branch that is not in 710pre7.

…l and RecoEgamma changes which migrated by accident
@slava77
Copy link
Contributor

slava77 commented May 8, 2014

So, if I trust jenkins, there are no changes at all.
Interesting, isn't it

@davidlange6
Copy link
Contributor

indeed, its interesting
seems like a problem:)

davidlange6 added a commit that referenced this pull request May 8, 2014
@davidlange6 davidlange6 merged commit f13adf7 into cms-sw:CMSSW_7_1_X May 8, 2014
@slava77
Copy link
Contributor

slava77 commented May 8, 2014

On 5/8/14, 12:04 PM, David Lange wrote:

indeed, its interesting
seems like a problem:)

I don't recall ever seeing a relevant difference from jenkins comparisons.


Reply to this email directly or view it on GitHub
#3631 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@ktf
Copy link
Contributor

ktf commented May 8, 2014

@slava77 you mean you have places where using RelMon by hand gives you
differences, or that RelMon itself is not a good way of running
comparisons?

@slava77
Copy link
Contributor

slava77 commented May 8, 2014

This is what I get for plain wf 5.1
https://slava77sk.web.cern.ch/slava77sk/reco/relvaldiffs/DQM_5.1_CMSSW_7_1_X_2014-05-05-1400-orig-resim_v_CMSSW_7_1_X_2014-05-05-1400-sign366orig-resim_0_1.pdf

The comparisons are made by looking at histograms in the same dir with the same name in the harvested DQM plots (the same stuff as RelMon, only I think this script may be even older than RelMon)
https://github.com/slava77/cms-reco-tools/blob/master/compareValHists.C

@ktf
Copy link
Contributor

ktf commented May 8, 2014

@nclopezo. Can you integrate this macro in the tests? You need to run it on the same DQM output.

@Martin-Grunewald
Copy link
Contributor

I find an error in today's 2AM build which has this PR integrated:

The error message is:

%MSG
----- Begin Fatal Exception 09-May-2014 08:11:01 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 2 event: 101
   [1] Running path 'prevalidation_step'
   [2] Calling event method for module GenJetSelector/'ak4GenJetsForPUid'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::GenJet>
Looking for module label: ak4GenJets
Looking for productInstanceName:

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exc\
eption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe\
t in the configuration.

----- End Fatal Exception -------------------------------------------------

and it occurs in a cmsDriver generated workflow:

# Auto generated configuration file
# using: 
# Revision: 1.19 
# Source: /local/reps/CMSSW/CMSSW/Configuration/Applications/python/ConfigBuilder.py,v 
# with command line options: RelVal --step=RAW2DIGI,L1Reco,RECO,VALIDATION,DQM --conditions=auto:startup_GRun --filein=file:RelVal_DigiL1RawHLT_GRun_STARTUP.root --custom_conditions= --fileout=RelVal_RECO_GRun_STARTUP.root --number=100 --mc --no_exec --datatier SIM-RAW-HLT-RECO --eventcontent=RAW --customise=HLTrigger/Configuration/CustomConfigs.Base --scenario=pp --python_filename=RelVal_RECO_GRun_STARTUP.py

Looks like somewhere the production of the (new) ak4GenJets got lost...

@davidlange6
Copy link
Contributor

Martin -
do we get a hint about how to see the error? The relvals are still running, so I guess no massive failures.

On May 9, 2014, at 8:29 AM, Martin Grunewald notifications@github.com
wrote:

I find an error in today's 2AM build which has this PR integrated:

The error message is:

%MSG
----- Begin Fatal Exception 09-May-2014 08:11:01 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 2 event: 101
[1] Running path 'prevalidation_step'
[2] Calling event method for module GenJetSelector/'ak4GenJetsForPUid'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vectorreco::GenJet
Looking for module label: ak4GenJets
Looking for productInstanceName:

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exc
eption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSe
t in the configuration.

----- End Fatal Exception -------------------------------------------------

and it occurs in a cmsDriver generated workflow:

Auto generated configuration file

using:

Revision: 1.19

Source: /local/reps/CMSSW/CMSSW/Configuration/Applications/python/ConfigBuilder.py,v

with command line options: RelVal --step=RAW2DIGI,L1Reco,RECO,VALIDATION,DQM --conditions=auto:startup_GRun --filein=file:RelVal_DigiL1RawHLT_GRun_STARTUP.root --custom_conditions= --fileout=RelVal_RECO_GRun_STARTUP.root --number=100 --mc --no_exec --datatier SIM-RAW-HLT-RECO --eventcontent=RAW --customise=HLTrigger/Configuration/CustomConfigs.Base --scenario=pp --python_filename=RelVal_RECO_GRun_STARTUP.py

Looks like somewhere the production of the (new) ak4GenJets got lost...


Reply to this email directly or view it on GitHub.

@Martin-Grunewald
Copy link
Contributor

I run a set of tests privately... indeed no massive failure, as it occurs only
in the cmsDriver VALIDATION step....

@perrotta
Copy link
Contributor

perrotta commented May 9, 2014

Hi Martin,
That HLT tests starts from generated events taken from some old RelVal
sample [1], which did not contain ak4 genjets yet (same as for other
addOn tests, see
#3631 (comment)
earlier in this thread). We must update them and make them pick some
newer one.
A.

[1]
--filein=/store/relval/CMSSW_5_3_6-START53_V14/R
elValProdTTbar/GEN-SIM/v2/00000/DE03BB7E-F429-E211-A0B4-001A928116CC.root
in RelVal_DigiL1RawHLT_GRun_STARTUP.py

Martin Grunewald notifications@github.com ha scritto:

I find an error in today's 2AM build which has this PR integrated:

The error message is:

%MSG
----- Begin Fatal Exception 09-May-2014 08:11:01 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 2 event: 101
   [1] Running path 'prevalidation_step'
   [2] Calling event method for module GenJetSelector/'ak4GenJetsForPUid'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::GenJet>
Looking for module label: ak4GenJets
Looking for productInstanceName:

   Additional Info:
      [a] If you wish to continue processing events after a  
ProductNotFound exc\
eption,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the  
"options" PSe\
t in the configuration.

----- End Fatal Exception -------------------------------------------------

and it occurs in a cmsDriver generated workflow:

# Auto generated configuration file
# using:
# Revision: 1.19
# Source:  
/local/reps/CMSSW/CMSSW/Configuration/Applications/python/ConfigBuilder.py,v
# with command line options: RelVal  
--step=RAW2DIGI,L1Reco,RECO,VALIDATION,DQM  
--conditions=auto:startup_GRun  
--filein=file:RelVal_DigiL1RawHLT_GRun_STARTUP.root  
--custom_conditions= --fileout=RelVal_RECO_GRun_STARTUP.root  
--number=100 --mc --no_exec --datatier SIM-RAW-HLT-RECO  
--eventcontent=RAW  
--customise=HLTrigger/Configuration/CustomConfigs.Base --scenario=pp  
--python_filename=RelVal_RECO_GRun_STARTUP.py

Looks like somewhere the production of the (new) ak4GenJets got lost...


Reply to this email directly or view it on GitHub:
#3631 (comment)


This message was sent using IMP, the Internet Messaging Program.

@Martin-Grunewald
Copy link
Contributor

Good point!

@nclopezo
Copy link
Contributor

nclopezo commented May 9, 2014

@nclopezo
Copy link
Contributor

@slava77
Could you send me an example on how to use compareValHists.C to generate that result? Thanks!

@slava77
Copy link
Contributor

slava77 commented May 12, 2014

On 5/12/14, 9:39 AM, David Mendez wrote:

@slava77 https://github.com/slava77
Could you send me an example on how to use compareValHists.C to generate
that result? Thanks!

Hi David,

source makeDiff.sh fileRef fileNew outputFile 0 dMod
# dMod = 0 to write all histograms with different content
# dMod = 1 for diffs with 1-KSprob > 1E-12
# dMod = 3 for diffs with 1-KSprob > 1E-3
# dMod = 2 for diffs with 1-KSprob > 0.9

the script is in the same https://github.com/slava77/cms-reco-tools

I think it's much better to fix the RelMon, it's much more user-friendly
in the presentation of outputs.

    --slava


Reply to this email directly or view it on GitHub
#3631 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@cmsbuild
Copy link
Contributor

@gpetruc gpetruc mentioned this pull request May 15, 2014
@ferencek ferencek mentioned this pull request Sep 24, 2014
@rappoccio rappoccio deleted the rappoccio_AK5_To_AK4_710pre7 branch November 3, 2014 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment