New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ecal_dqm_sourceclient and hlt_dqm_sourceclient to Run-3 era #36946
Conversation
type bug-fix |
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36946/28292
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
We discussed this internally and for the moment we will have to go with this solution for the MWGR and fix it for CRAFT. |
@jfernan2 is there any reason why you signed the 12_2_X backport and not this one in the master? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d12c61/22376/summary.html Comparison SummarySummary:
|
I think it's just that the Jenkins tests came back earlier for that PR (which is weird as the tests were started later) |
That's it, when I signed tests were not available in this one |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
To resolve the issue in #36940 (comment)
Shamelessly copied from Marco here:
#36944 (comment)
if this PR is a backport please specify the original PR and why you need to backport that PR:
Should be backported to 12_2_X
Resolves #36944