Update to L1 prescale code following move to fractional prescales #37046
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37046/28481
|
|
A new Pull Request was created by @lathomas for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hmm, I believe you still need to code a HLT customisation procedure deleting the parameter PrescaleCSVFile = cms.string( "prescale_L1TGlobal.csv") in all instances of L1TGlobalProducer appearing in the HLT menus: |
|
please test |
|
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MomentumDependentPedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/PedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/RunRangeDependentPedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/ZMuMuMassConstraintParameterFinder.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc: In member function 'std::pair MillePedeAlignmentAlgorithm::addReferenceTrajectory(const edm::EventSetup&, const AlignmentAlgorithmBase::EventInfo&, const value_type&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc:517:24: error: 'class gbl::GblPoint' has no member named 'numMeasurements'; did you mean 'addMeasurement'?
517 | if (itPoint->numMeasurements() >= 1)
| ^~~~~~~~~~~~~~~
| addMeasurement
gmake: *** [tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/MillePedeAlignmentAlgorithm.cc.o] Error 1
>> Building edm plugin tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/libAlignmentMillePedeAlignmentAlgorithmAuto.so
Clang BuildI found compilation error while trying to compile with clang. Command used: >> Entering Package RecoTracker/TkDetLayers >> Entering Package RecoTracker/TkNavigation >> Entering Package RecoTracker/TkSeedingLayers >> Entering Package RecoTracker/TransientTrackingRecHit >> Compile sequence completed for CMSSW CMSSW_12_3_X_2022-02-22-2300 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/tmp/slc7_amd64_gcc10/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package Alignment/MillePedeAlignmentAlgorithm Entering library rule at src/Alignment/MillePedeAlignmentAlgorithm/plugins >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-22-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeDQMModule.cc |
cmsbuild
added
code-checks-pending
hlt-pending
tests-pending
and removed
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37046/28486
|
|
Pull request #37046 was updated. @Martin-Grunewald, @rekovic, @epalencia, @cmsbuild, @missirol, @cecilecaillol can you please check and sign again. |
|
please test |
|
Let's hope it picks the 11AM build... |
I remember reading this comment. Based on that, I would expect |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d503c/22623/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+hlt The change in the HLT pkg concerns only the removal of 1 unused plugin parameter, see
|
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
(looks like I messed up with the push force on the previous PR #37040 so just restarting from scratch)
This PR adds a new EventSetup producer producing L1TGlobalPrescalesVetosFractRcd (the L1 prescale table), a record similar to the previous L1TGlobalPrescalesVetosRcd which is not in use anymore.
This producer is used to overwrite the prescale table (with the help of two dedicated config files) and this update is rather urgently needed for trigger studies at L1 and HLT.
We also take this opportunity to drop from L1TGlobalProducer an unused (and quite confusing) parameter supposed to provide a prescale table in CSV format which is actually not used.
PR validation:
Tested with wf 11834.0 which includes DIGI/L1/DIGI2RAW/HLT steps.
The use of the producer was tested and allowed to modify L1 prescales as expected.