New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new scenario for ECAL ALCANANO and update the unit test #37627
Conversation
FYI @simonepigazzini @cms-sw/alca-l2 @mmusich @rappoccio |
urgent
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37627/29398
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@tvami |
Hi Marco, the file is not empty, the change is "empty", I changed the permissions of the file, earlier it was not executable so when I tried to run the unit test line directly, I got permission denied. Do you think think I should change back the permissions? |
Not sure, I usually invoked the script by calling it with |
That leads to
|
oh but doing |
eaea2d2
to
66debc8
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37627/29400
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-104cbf/24033/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@cms-sw/operations-l2 the tests came back positive, please consider signing this |
66debc8
to
29db0e6
Compare
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37627/29411
|
Pull request #37627 was updated. @perrotta, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-104cbf/24053/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
By doing the T0 replay
dmwm/T0#4664
I realized that the relvals run
and the customization in T0 happens through scenarios, so this PR adds the needed scenario.
PR validation:
scram b runtests
runs and produces a config that for example contains theecalMultiFitUncalibRecHitTask
task.if this PR is a backport please specify the original PR and why you need to backport that PR:
Needs to be backported to 12_3_X for dmwm/T0#4664 to work