Run2-gex132A Restore the names GeometryExtended2017 to let the unit tests to succeed

[bsunanda]

PR description:

Restore the names GeometryExtended2017 to let the unit tests to succeed.. 2017 is a copy of 2017Plan1. Also changed 2018 to 2018Plan0 and copy 2018Plan36 as 2018. These actions came after discussion at the SIM meeting on April 22,2022\

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37674/29493

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@civanch @cvuosalo @srimanob @perrotta @qliphy This will resolve the unit test issue

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-594366/24202/summary.html
COMMIT: 8b37274
CMSSW: CMSSW_12_4_X_2022-04-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37674/24202/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-594366/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695398
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[qliphy]

type bugfix

[srimanob]

I think the PR makes confusion (to me):

• Restoring happen only for 2017 (bring back GeometryExtended2017_cff.py)
• Following the plan presented in SIM meeting (https://indico.cern.ch/event/1153217/contributions/4842354/attachments/2429679/4163061/Sim-Talk146.pdf), slide 5, we should have GeometryExtended2017_cff anyways from 2017Plan1. If this is the case, will this PR is just temporary until the new one will be available?
• If nothing to do with 2018 for bug-fix type, e.g. fix unit test, I propose we remove 2018 out from the PR.

[bsunanda]

In the meeting we decided to have 2017(Reco)_cff and 2018(Reco)_cff to reflect the default seetings of the year which are copies of Plan1 and Plan36 respectively. The new PR's which will match the dd4hep version will be called 201XY(Reco)_cff with X = 7 or 8 and Y = DDD for DDD version and DD4hep for the other version. Accordingly 2 PR's are submittied.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37674/29499

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #37674 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

[srimanob]

Hi @bsunanda
I mean this PR fixes the unit test issue by bring back only GeometryExtended2017_cff. The PR title and description makes it sound like we are missing both 2017 and 2018.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-594366/24212/summary.html
COMMIT: 3b73485
CMSSW: CMSSW_12_4_X_2022-04-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37674/24212/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-594366/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

This PR fixes the unit test issue on Run-2 2017 geometry. It also includes an update on 2018 XML. We should not see any changes in PR test as Run-2 wf runs with geometry in DB, not in XML.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1