Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing runtime cms::Exception calls with edm::LogError calls in the jet flavour code #3785

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented May 9, 2014

Following discussion in the RECO/AT meeting on May 8, 2014 (https://indico.cern.ch/event/317592/#2014-05-08), this PR replaces runtime cms::Exception calls with edm::LogError calls in the jet flavour code

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_1_X.

Replacing runtime cms::Exception calls with edm::LogError calls in the jet flavour code

It involves the following packages:

PhysicsTools/JetMCAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #3785 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@vadler
Copy link

vadler commented May 12, 2014

I can see #3785 (comment) , but I don't see a corresponding commit. Should that be the fix for #3785 (comment) ?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ferencek
Copy link
Contributor Author

I think #3785 (comment) was a delayed automatic response on the last commit added to this branch which cleans up the code a bit.

@vadler
Copy link

vadler commented May 12, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 12, 2014
…SW_7_1_X_2014-05-09-1400

AT -- Replacing runtime cms::Exception calls with edm::LogError calls in the jet flavour code
@ktf ktf merged commit 29251f6 into cms-sw:CMSSW_7_1_X May 12, 2014
@ferencek ferencek deleted the JetFlavourLogError_from-CMSSW_7_1_X_2014-05-09-1400 branch May 12, 2014 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants