Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_4_X] Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* #38265

Merged
merged 2 commits into from Jun 8, 2022
Merged

[12_4_X] Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* #38265

merged 2 commits into from Jun 8, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jun 6, 2022

PR description:

See #38252 and #38090

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38252 and #38090

@tvami tvami changed the title Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* [12_4_X] Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* Jun 6, 2022
@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Jun 6, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022 •
edited

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • DQM/TrackerRemapper (dqm)
  • EventFilter/CSCRawToDigi (reconstruction)
  • EventFilter/CTPPSRawToDigi (reconstruction)
  • EventFilter/GEMRawToDigi (reconstruction)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/HcalCommonData (geometry)
  • Geometry/HcalTowerAlgo (geometry)
  • Geometry/TrackerCommonData (geometry)
  • Geometry/VeryForwardData (geometry)
  • L1Trigger/CSCTriggerPrimitives (l1)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoParticleFlow/PFProducer (reconstruction)
  • RecoTracker/MkFit (reconstruction)
  • SimG4CMS/Calo (simulation)
  • SimG4CMS/Forward (simulation)
  • SimG4CMS/Muon (simulation)
  • SimG4CMS/ShowerLibraryProducer (simulation)
  • SimG4Core/Configuration (simulation)
  • SimG4Core/PhysicsLists (simulation)
  • SimG4Core/PrintGeomInfo (simulation)
  • SimMuon/RPCDigitizer (simulation)
  • SimPPS/Configuration (simulation)
  • SimTracker/TrackerMaterialAnalysis (simulation)
  • Validation/CSCRecHits (dqm)
  • Validation/Geometry (geometry, dqm)
  • Validation/MuonCSCDigis (dqm)
  • Validation/RecoParticleFlow (dqm)

@ianna, @rekovic, @cecilecaillol, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @pmandrik, @Dr15Jones, @epalencia, @cvuosalo, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @slava77, @jpata, @micsucmed, @francescobrivio, @malbouis, @clacaputo, @srimanob, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@jhgoh, @grzanka, @felicepantaleo, @hatakeyamak, @ghugo83, @jshlee, @bsunanda, @eyigitba, @fioriNTU, @thomreis, @trtomei, @rishabhCMS, @threus, @mmusich, @seemasharmafnal, @venturia, @mmarionncern, @hdelanno, @vargasa, @makortel, @JanFSchulte, @watson-ij, @dgulhan, @valuev, @apsallid, @slomeo, @simonepigazzini, @lgray, @giovanni-mocellin, @barvic, @cvuosalo, @fabferro, @GiacomoSguazzoni, @tocheng, @VinInn, @missirol, @ptcox, @rovere, @jandrea, @idebruyn, @ebrondol, @argiro, @mtosi, @fabiocos, @rbartek, @Martin-Grunewald, @rchatter, @beaucero, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jun 6, 2022

type gem

@cmsbuild cmsbuild added the gem label Jun 6, 2022
@tvami
Copy link
Contributor Author

tvami commented Jun 6, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0b098/25320/summary.html
COMMIT: 2e2d7b5
CMSSW: CMSSW_12_4_X_2022-06-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38265/25320/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-fed_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-hcalreco_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-hcal_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS
and more ...

RelVals

  • 4.534.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
  • 8.08.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
  • 9.09.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.174.17_RunMinBias2011A+RunMinBias2011A+HLTD+RECODR1reHLT+HARVESTDR1reHLT+SKIMDreHLT/step2_RunMinBias2011A+RunMinBias2011A+HLTD+RECODR1reHLT+HARVESTDR1reHLT+SKIMDreHLT.log
  • 4.234.23_ValSkim2011A+ValSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT/step2_ValSkim2011A+ValSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT.log
  • 4.244.24_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT/step2_WMuSkim2011A+WMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT.log
Expand to see more relval errors ...

AddOn Tests

  • fastsimcmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Mon Jun 6 22:37:19 2022-date Mon Jun 6 22:36:58 2022 s - exit: 256
  • fastsim1cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Mon Jun 6 22:37:19 2022-date Mon Jun 6 22:37:03 2022 s - exit: 256
  • fastsim2cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Mon Jun 6 22:37:19 2022-date Mon Jun 6 22:37:04 2022 s - exit: 256
Expand to see more addon errors ...

@tvami tvami force-pushed the RenameTo2022_Backport124X branch from 2e2d7b5 to fb4a315 Compare June 6, 2022 21:23
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

Pull request #38265 was updated. @ianna, @Martin-Grunewald, @rekovic, @cecilecaillol, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @missirol, @pmandrik, @Dr15Jones, @epalencia, @cvuosalo, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @slava77, @jpata, @micsucmed, @francescobrivio, @malbouis, @clacaputo, @srimanob, @tvami, @rvenditti can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Jun 6, 2022

@cmsbuild , please test

@missirol
Copy link
Contributor

missirol commented Jun 8, 2022

Hi @cms-sw/alca-l2 , what's the plan to backport #38283 to 12_4_X? (it is needed by #38242)

Could that backport be added to this PR? (maybe that's faster)

@tvami
Copy link
Contributor Author

tvami commented Jun 8, 2022

I think the plan is to have this merged today, while having #38242 and #38283 merged today. So then we can submit the backport of them tomorrow, have them merged by Friday.

@cecilecaillol
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

srimanob commented Jun 8, 2022

+Upgrade

backport pr

@bbilin
Copy link
Contributor

bbilin commented Jun 8, 2022

+1

@missirol
Copy link
Contributor

missirol commented Jun 8, 2022

@tvami

I think the plan is to have this merged today, while having #38242 and #38283 merged today. So then we can submit the backport of them tomorrow, have them merged by Friday.

Okay. To be clear, #38283 goes hand-in-hand with #38241 (not #38242).

Anyways, if we'll have a 12_4_X backport of #38283 tomorrow (to help #38242), I think it will be okay. Thanks for clarifying.

@jpata
Copy link
Contributor

jpata commented Jun 8, 2022

+reconstruction

  • technical renaming of GTs
  • no reco changes (most of the code changes are in /test/, so it's possible private codes may have to take note of this change)
  • the reco part is a backport of Rename phase1_2021* to phase1_2022* #38252

@tvami
Copy link
Contributor Author

tvami commented Jun 8, 2022

@qliphy
can we aim to have this merged for 2300 IB ?

@pmandrik
Copy link
Contributor

pmandrik commented Jun 8, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 8, 2022

+1

@cmsbuild cmsbuild merged commit 0e6cff5 into cms-sw:CMSSW_12_4_X Jun 8, 2022
@qliphy qliphy mentioned this pull request Jun 8, 2022
Merged
This was referenced Jun 9, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved backport-ok dqm-approved fully-signed gem geometry-approved hlt-approved l1-approved orp-approved pdmv-approved reconstruction-approved simulation-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_12_4_X
Development

Successfully merging this pull request may close these issues.

None yet