Introduce era with CKF pixelLessStep

[mmasciov]

PR description:

This PR introduces a new era modifier where mkFit is disabled for PixelLessStep.
This is meant as a (temporary) fix for the inefficiency previously reported by BPH (https://indico.cern.ch/event/1166179/#3-feedback-from-bph-on-mkfit).

PR validation:

As described in https://indico.cern.ch/event/1169208/#5-mkfit-cross-check-of-ineffic

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38437/30638

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): Rawprime workflow with approximated siStrip clusters for heavy ions #38423

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

• Configuration/Eras (operations)
• RecoTracker/IterativeTracking (reconstruction)

@perrotta, @clacaputo, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-753264/25645/summary.html
COMMIT: 0d151a0
CMSSW: CMSSW_12_5_X_2022-06-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38437/25645/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Plugins of all types refreshed.
gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1826: CompilePython] Error 1
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/pool/condor/dir_155243/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-20-1100'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1714: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /pool/condor/dir_155243/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /pool/condor/dir_155243/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-20-1100/tmp/el8_amd64_gcc10/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Configuration/Eras


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38437/30644

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): Rawprime workflow with approximated siStrip clusters for heavy ions #38423

[cmsbuild]

Pull request #38437 was updated. @perrotta, @clacaputo, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-753264/25646/summary.html
COMMIT: 26b5580
CMSSW: CMSSW_12_5_X_2022-06-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38437/25646/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659099
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3659069
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• new era Run3_ckfPixelLessStep to partly disable mkFit (will change reco)
• not enabled by default

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[francescobrivio]

I'm helping @bbilin understand why this new Era is not recognized when running the driver in 12_4_1 with error:

raise Exception( "'%s' is not a valid option for '--era'. Valid options are %s." % (eraName, validOptions) )
Exception: 'Run3_ckfPixelLessStep' is not a valid option for '--era'. Valid options are 'Run1_pA', 'Run1_peripheralPbPb', 'Run2_50ns', 'Run2_50ns_HIPM', 'Run2_25ns', 'Run2_25ns_HIPM', 'Run2_25ns_peripheralPbPb', 'Run2_HI', 'Run2_2016', 'Run2_2016_HIPM', ....

I guess the new era should have been added in:

cmssw/Configuration/StandardSequences/python/Eras.py

Lines 36 to 41 in 3b20114

	'Run3',
	'Run3_noMkFit',
	'Run3_pp_on_PbPb',
	'Run3_dd4hep',
	'Run3_DDD',
	'Run3_FastSim',

@cms-sw/reconstruction-l2 can you confirm?

FYI @perrotta @qliphy @rappoccio

[jpata]

I guess the new era should have been added in cmssw/Configuration/StandardSequences/python/Eras.py
can you confirm?

I don't have first-hand knowledge with it, but reading the code, this looks to be the case. Does it work when you add it there?

[perrotta]

I guess the new era should have been added in cmssw/Configuration/StandardSequences/python/Eras.py
can you confirm?

I don't have first-hand knowledge with it, but reading the code, this looks to be the case. Does it work when you add it there?

CMSSW_12_4_1_patch1 was built this morning with that fix included.

[francescobrivio]

I guess the new era should have been added in cmssw/Configuration/StandardSequences/python/Eras.py
can you confirm?

I don't have first-hand knowledge with it, but reading the code, this looks to be the case. Does it work when you add it there?

Yes the era needs to be added there, also there was a typo in the name of the config file:

Configuration/Eras/python/Era_Run3_ckfPixelLessStep.py 
--> 
Configuration/Eras/python/Era_Run3_ckfPixelLessStep_cff.py

See the PRs from Mario linked just above with the fixes.