Add Transformer ability to modules #38454
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38454/30666
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
cmsbuild
added
tests-started
tests-rejected
and removed
tests-pending
tests-started
labels
|
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Leaving Package AnalysisAlgos/SiStripClusterInfoProducer
>> Package AnalysisAlgos/SiStripClusterInfoProducer built
Entering library rule at src/AnalysisAlgos/SiStripClusterInfoProducer/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/AnalysisAlgos/SiStripClusterInfoProducer/plugins/SiStripProcessedRawDigiProducer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/AnalysisAlgos/SiStripClusterInfoProducer/plugins/SiStripProcessedRawDigiProducer.cc: In member function 'void SiStripProcessedRawDigiProducer::pr_process(const edm::DetSetVector&, edm::DetSetVector&, const SiStripGain&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/AnalysisAlgos/SiStripClusterInfoProducer/plugins/SiStripProcessedRawDigiProducer.cc:126:5: error: 'virtual void edm::stream::EDProducerBase::transform(std::size_t, edm::EventForTransformer&) const' is private within this context
126 | transform(
| ^~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/FWCore/Framework/interface/stream/implementors.h:31,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/FWCore/Framework/interface/stream/AbilityToImplementor.h:25,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/FWCore/Framework/interface/stream/EDProducer.h:22,
Clang BuildI found compilation error while trying to compile with clang. Command used: >> Entering Package RecoMuon/MuonSeedGenerator >> Entering Package RecoMuon/StandAloneMuonProducer >> Entering Package SimG4Core/Application >> Entering Package SimGeneral/MixingModule >> Compile sequence completed for CMSSW CMSSW_12_5_X_2022-06-21-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/tmp/el8_amd64_gcc10/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package DataFormats/Provenance Entering library rule at DataFormats/Provenance >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-21-1100/src/DataFormats/Provenance/src/BranchChildren.cc |
Dr15Jones
force-pushed
the
produceTransform
branch
from
7346305
to
998a628
Compare
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-rejected
code-checks-approved
labels
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38454/30682
|
|
Pull request #38454 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38454/32060
|
|
Pull request #38454 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
|
@cmsbuild, please test |
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
|
So while in #38454 (comment) and #38454 (comment) the test succeeded. The failure is not caused by the developments of this PR, but gets somehow triggered based on what packages get checked out and if the IB is patch or full release (CMSSW_12_6_X_2022-09-09-1100 is a patch release). I suggest we go a head with this PR, and investigate this failure mode of |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
merge |
PR description:
Added ability to register
tranformmethods to modules. This allows a module to have a method which takes a data product already put into the Event by the same module and then create a new data product from it which is also put into the Event.The plan is to use this ability to implement an automatic conversion from GPU to CPU data products.
PR validation:
Code compiles and new unit test passes.