Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new HI Beamspot to the Run-3 HI MC + change vertex smearing to use the estimated HI version #39758

Merged
merged 1 commit into from Nov 1, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Oct 18, 2022

PR description:

Add new HI Beamspot as requested in https://cms-talk.web.cern.ch/t/request-for-new-run3-hi-mc-gt-updated-reco-bs-for-12-5-x/16447

The diff wrt to the prev GT is just the beamspot tag
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022_realistic_HI_v4/125X_mcRun3_2022_realistic_HI_v6

Change the input GEN-SIM to CMSSW_12_5_1-125X_mcRun3_2022_realistic_HI_v5-v1 created in the JIRA https://its.cern.ch/jira/browse/PDMVRELVALS-174

PR validation:

RelVals have to be modified for the real test, @mandrenguyen will take care of that.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but needs to go back to 12_5_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39758/32616

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Oct 18, 2022

@cmsbuild , please test

  • tho I expect this to be inconsistent with the gen beamspot

@tvami tvami changed the title Add new HI Beamspot to the Run-3 HI MC Add new HI Beamspot to the Run-3 HI MC + change vertex smearing to use the estimated HI version Oct 18, 2022
@tvami
Copy link
Contributor Author

tvami commented Oct 18, 2022

test parameters:

  • workflows = 159, 159.02, 159.03

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39758/32623

  • This PR adds an extra 52KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

Pull request #39758 was updated. @malbouis, @yuanchao, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Oct 18, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70708b/28348/summary.html
COMMIT: f4b4da1
CMSSW: CMSSW_12_6_X_2022-10-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39758/28348/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70708b/28348/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70708b/28348/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_56387/jenkins/workspace/compare-root-files-short-matrix/data/PR-70708b/159.02_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2021PPRECOMBAPPROXCLUSTERS+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO4
  • /pool/condor/dir_56387/jenkins/workspace/compare-root-files-short-matrix/data/PR-70708b/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17726 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3585766
  • DQMHistoTests: Total failures: 87908
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3497833
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.037 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 1.037 KiB SiStrip/MechanicalView
  • Checked 217 log files, 48 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 9 / 48 workflows

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39758/32876

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

Pull request #39758 was updated. @malbouis, @yuanchao, @bbilin, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70708b/28691/summary.html
COMMIT: 5c2c52b
CMSSW: CMSSW_12_6_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39758/28691/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70708b/159.02_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2021PPRECOMBAPPROXCLUSTERS+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO4
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70708b/159.03_HydjetQ_MinBias_5020GeV_2021_ppReco+HydjetQ_MinBias_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RAWPRIMESIMHI18+RECOHI2022PROD+MINIHI2022PROD

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2235 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3610974
  • DQMHistoTests: Total failures: 13071
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3597880
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 222 log files, 48 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2022

unhold

@cmsbuild cmsbuild removed the hold label Nov 1, 2022
@francescobrivio
Copy link
Contributor

+alca

@tvami
Copy link
Contributor Author

tvami commented Nov 1, 2022

@srimanob can you please re-sign?

@bbilin
Copy link
Contributor

bbilin commented Nov 1, 2022

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Nov 1, 2022

+Upgrade

Re-sign.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 1, 2022

+1

@cmsbuild cmsbuild merged commit bb00e9c into cms-sw:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants