Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_5_X] Nano: fix matching between pat trigger objects and L1 objects #39954

Merged
merged 1 commit into from Nov 2, 2022

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Nov 2, 2022

PR description:

Fix bug with matching between PAT trigger objects and L1 objects reported in #39809.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #39893, as requested in #39932 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

A new Pull Request was created by @swertz (Sbastien Wertz) for CMSSW_12_5_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor Author

swertz commented Nov 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1237f9/28731/summary.html
COMMIT: 5fb7903
CMSSW: CMSSW_12_5_X_2022-11-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39954/28731/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734344
  • DQMHistoTests: Total failures: 59
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3734262
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@swertz
Copy link
Contributor Author

swertz commented Nov 2, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

backport of #39893

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@cmsbuild cmsbuild merged commit 61e987b into cms-sw:CMSSW_12_5_X Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants