Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in matching between HLT object and L1 object #39809

Closed
jaimeleonh opened this issue Oct 21, 2022 · 8 comments
Closed

Issue in matching between HLT object and L1 object #39809

jaimeleonh opened this issue Oct 21, 2022 · 8 comments

Comments

@jaimeleonh
Copy link
Contributor

jaimeleonh commented Oct 21, 2022

When running the nanoAOD production, in https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc#L252-L255 there's a loop that tries to find the L1 object that best matches (in dR) with the desired HLT object. However, the best value is not getting updated, so the last L1object from the collection whose dR with the HLT object is smaller than sel.l1DR2 (which to be true I'm not sure what is), is the one getting stored, even if there's a previous one with an smaller dR. Is this behaviour intended?

@cmsbuild
Copy link
Contributor

A new Issue was created by @jaimeleonh Jaime Leon Holgado.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign xpog

@cmsbuild
Copy link
Contributor

New categories assigned: xpog

@swertz,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@swertz
Copy link
Contributor

swertz commented Oct 27, 2022

Thanks for reporting @jaimeleonh , this looks like a bug indeed. I will make a PR to fix it and backport it to 124X. However we are planning to change the way trigger object info is stored in nano as this is not the only issue with the TriggerObjectTableProducer...

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

This looks like having been fixed in master by #39893
Also the backport in 12_4 is available, #39932, while the one in 12_5_X is still missing: I suggest to keep this issue open until also the backport in the intermediate release is available

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

urgent

@swertz
Copy link
Contributor

swertz commented Nov 2, 2022

+xpog

Fixed in #39893 and backports #39932 and #39954

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This issue is fully signed and ready to be closed.

@perrotta perrotta closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants