New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiMuonValidation
to the TkAl "new" all-in-one tool
#40346
Add DiMuonValidation
to the TkAl "new" all-in-one tool
#40346
Conversation
type trk |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40346/33436
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assing trk-dpg |
@cmsbuild, please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
f5f78da
to
be3128a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40346/33456
|
Pull request #40346 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again. |
@cmsbuild, please test |
Pull request #40346 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11be3c/29708/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
…lineValidation_13_0_X `Zmumumerge`: post-merge comments to #40346
PR description:
This is a follow-up to #38304
Add the Di-Muon mass bias alignment validation to the new all-in-one alignment validation tool introduced in #38304.
Work originally done in cms-trackeralign#21 but never converged internally (hence missed the original PR)
PR validation:
Run the package unit tests:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A
FYI
@consuegs @antoniovagnerini