Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto generated cfi files in tracker alignment all-in-one validation tool #40695

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 4, 2023

PR description:

This PR addresses the discussion at #40677 (comment) by providing fillDescriptions methods for all the plugins used in the tracker alignment all-in-one validation meta-tool and propagating the auto generated cfi files generated in this way to the various configuration files used in cmssw.

PR validation:

Relies on the existing unit tests.
Run successfully scram b runtests use-ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40695/34055

  • This PR adds an extra 100KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 4, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40695/34056

  • This PR adds an extra 100KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2023

Pull request #40695 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 4, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40695/34059

  • This PR adds an extra 108KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2023

Pull request #40695 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 5, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65d2b3/30406/summary.html
COMMIT: 2427f1b
CMSSW: CMSSW_13_0_X_2023-02-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40695/30406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 6, 2023

+alca

  • relevant unit tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants