Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in parameter name - should be automatically forwarded to 72X as well #4405

Merged
merged 2 commits into from Jul 3, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Fix typo in parameter name - should be automatically forwarded to 72X as well

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_1_X.

Fix typo in parameter name - should be automatically forwarded to 72X as well

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #4405 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Jun 26, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Jun 27, 2014

This also adds a customise. Is that expected?

@Martin-Grunewald
Copy link
Contributor Author

Yes, it had been forgotten.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jul 1, 2014
Cfi file fixes for 72X (same as already for 71X: #4405 and #4413)
davidlange6 added a commit that referenced this pull request Jul 3, 2014
Fix typo in parameter name - should be automatically forwarded to 72X as well
@davidlange6 davidlange6 merged commit c830872 into cms-sw:CMSSW_7_1_X Jul 3, 2014
@Martin-Grunewald Martin-Grunewald deleted the FixTypo branch July 4, 2014 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants