Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pat::Electron source PFCand accessor in miniAOD #4862

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 1, 2014

References from pat::Electron to packed PFCandidates are correctly stored in the miniAODs, but the accessor that returns them had a bug.
This commit fixes the problem in the accessor.
It does not need to reproduce the miniAODs, it does not change the persistent dataformat, and in general it doesn't affect miniAOD production in any way.
It also doesn't need to recompile any dependency for it to work, since the fix is localized in a cc file.

@arizzi @bendavid

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_0_X.

fix pat::Electron source PFCand accessor in miniAOD

It involves the following packages:

DataFormats/PatCandidates

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

Pull request #4862 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

@monttj
Copy link
Contributor

monttj commented Aug 1, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Aug 4, 2014
…_0_6_patch1

fix pat::Electron source PFCand accessor in miniAOD
@davidlange6 davidlange6 merged commit 4adb315 into cms-sw:CMSSW_7_0_X Aug 4, 2014
davidlange6 added a commit that referenced this pull request Sep 26, 2014
…37_5230_From720pre6Plus5425

Same as #5525 (#4914 #4833 #4862 #5037 #5230 plus #5425 and other fixes) MiniAOD related
nclopezo added a commit that referenced this pull request Oct 1, 2014
…37_5230_From720pre6Plus5425

Miniaod ports of #4914 #4833 #4862 #5037 #5230  plus #5425 and other fixes
@gpetruc gpetruc deleted the fixEleSourcePFCands-fromCMSSW_7_0_6_patch1 branch September 30, 2015 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants