New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacement of TMatrix and TVector by SMatrix and SVector in MET code #5417
Conversation
…17-0200 FWCore: add support for Address Sanitizer IBs
A new Pull Request was created by @mmarionncern for CMSSW_7_3_X. Replacement of TMatrix and TVector by SMatrix and SVector in MET code It involves the following packages: DataFormats/METReco @nclopezo, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @ktf can you please review it and eventually sign? Thanks. |
@mmarionncern can you test your changes with latest 73X IB? I get |
Also, can you prepare a PR for 72X too, it seems offline would like to push for 72X after all. |
I think I am not doing the proper actions with the rebase... What should I do to make it working? |
Following the tutorial for the forward-porting, it appears that after the rebase, the git push command tells me everything is up to date, so with no action taken... |
I am not a git guru but I'll try to resolve it - leave that to me for now and work on the other stuff. |
False alarm - now with CMSSW_7_3_X_2014-09-19-0200 I get exactly what I should. I'll test with this version. |
Replacement of TMatrix and TVector by SMatrix and SVector in MET code
Removed any instance of TMatrix and TVector in benefit to SMatrix and SVector in the MET significance code and MET code, used to keep the covariance matrix.
An extra typedef has been declared in DataFormat/METReco/interface/MET.h to standardize the definition of the MET covariance matrix.
This PR is necessary to complete the PR #5388