Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of TMatrix and TVector by SMatrix and SVector in MET code #5417

Merged
merged 6 commits into from Sep 22, 2014

Conversation

mmarionncern
Copy link

Removed any instance of TMatrix and TVector in benefit to SMatrix and SVector in the MET significance code and MET code, used to keep the covariance matrix.
An extra typedef has been declared in DataFormat/METReco/interface/MET.h to standardize the definition of the MET covariance matrix.

This PR is necessary to complete the PR #5388

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_3_X.

Replacement of TMatrix and TVector by SMatrix and SVector in MET code

It involves the following packages:

DataFormats/METReco
FWCore/Framework
FWCore/ParameterSet
FWCore/PluginManager
RecoMET/METAlgorithms

@nclopezo, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @ktf can you please review it and eventually sign? Thanks.
@TaiSakuma, @schoef, @nhanvtran, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@mmarionncern can you test your changes with latest 73X IB? I get
9 files changed, 50 insertions(+), 48 deletions(-)
with CMSSW_7_3_X_2014-09-18-0200 vs yours
12, +65, −54 . Probably you have to rebase. Let me know.

@StoyanStoynev
Copy link
Contributor

Also, can you prepare a PR for 72X too, it seems offline would like to push for 72X after all.

@cmsbuild
Copy link
Contributor

@mmarionncern
Copy link
Author

I think I am not doing the proper actions with the rebase... What should I do to make it working?

@mmarionncern
Copy link
Author

Following the tutorial for the forward-porting, it appears that after the rebase, the git push command tells me everything is up to date, so with no action taken...
I am probably missing something stupid, but I don't see what I am doing wrong.

@StoyanStoynev
Copy link
Contributor

I am not a git guru but I'll try to resolve it - leave that to me for now and work on the other stuff.

@StoyanStoynev
Copy link
Contributor

False alarm - now with CMSSW_7_3_X_2014-09-19-0200 I get exactly what I should. I'll test with this version.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For c6b1b0b. Identical to #5440 (for 72X) - see the review there. Jenkins here show some known (previously observed) irreproducibility issues and nothing more. This PR (transition to SMatrix in the MET code) is needed for #5388 .

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 22, 2014
Replacement of TMatrix and TVector by SMatrix and SVector in MET code
@ktf ktf merged commit 0fccc4b into cms-sw:CMSSW_7_3_X Sep 22, 2014
@mmarionncern mmarionncern deleted the 72X_METMatrixChange branch November 14, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants