Major JME developments for 73x, Redux #6496
Conversation
…going to contain more stuff
…due to the ValueMap constraints
…some test sequences
|
A new Pull Request was created by @rappoccio for CMSSW_7_3_X. Major JME developments for 73x, Redux It involves the following packages: CommonTools/PileupModules The following packages do not have a category, yet: CommonTools/PileupModules @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
-1 Entering library rule at src/Calibration/IsolatedParticles/plugins
Entering library rule at src/Calibration/IsolatedParticles/plugins
Entering library rule at src/Calibration/IsolatedParticles/plugins
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-11-19-0200/src/CommonTools/PileupModules/plugins/PuppiProducer.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-11-19-0200/src/CommonTools/PileupModules/plugins/SoftKillerProducer.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-11-19-0200/src/CommonTools/PileupModules/plugins/SoftKillerProducer.cc:35:41: fatal error: fastjet/contrib/SoftKiller.hh: No such file or directory
#include "fastjet/contrib/SoftKiller.hh"
^
compilation terminated.
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-11-19-0200/src/CommonTools/PileupModules/plugins/SoftKillerProducer.cc:35:41: fatal error: fastjet/contrib/SoftKiller.hh: No such file or directory
#include "fastjet/contrib/SoftKiller.hh"
you can see the results of the tests here: |
|
Pull request #6496 was updated. @civanch, @nclopezo, @mdhildreth, @cmsbuild, @franzoni, @StoyanStoynev, @slava77, @mulhearn, @davidlange6 can you please check and sign again. |
cmsbuild
added
comparison-pending
new-package-pending
orp-pending
pending-signatures
reconstruction-pending
tests-pending
and removed
comparison-pending
l1-pending
new-package-pending
operations-pending
orp-pending
pending-signatures
reconstruction-pending
simulation-pending
tests-pending
labels
|
Pull request #6496 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again. |
| @@ -23,3 +23,11 @@ | |||
| distMax = cms.double(0.8), | |||
| value = cms.string('mass') | |||
| ) | |||
|
|
|||
|
|
|||
| ak8PFJetsCHSSoftDropLinks = cms.EDProducer("RecoJetDeltaRValueMapProducer", | |||
There was a problem hiding this comment.
Wouldn't it be better to call this and similar ValueMaps ak8PFJetsCHSSoftDropMass? That would make it clearer what these ValueMaps contain. In addition, the code is quite generic and one could store other quantities, such as jet Pt, in a similar way so 'Links' is maybe a bit too generic. What do you think?
Rebase of #6273. Copy-and-pasting the text of that PR :
This PR contains a large number of JME developments for 73x :
Updates to use new fastjet 3.1.0 (cms-externals/fastjet#8)
Updates to new API for n-subjettiness for fastjet-contrib 1.014 (cms-externals/fastjet-contrib#2)
Added changes to PUPPI from the code review here (#5500)
Added several new tools, none of which are to be executed in RECO until further notice :
Constituent subtraction
SoftKiller
SoftDrop
PUPPI
Two notes :
There is a new package, CommonTools/PileupModules. It would aid development to have these separate from CommonTools/ParticleFlow (which is focused on the "top projection" code).
The current output is set up as an intermediate stage where PFCandidates are produced along with a valueMap of four vectors. This is a stand-in until I make a migration to the ThinnedCollection, but this is better treated together rather than piecemeal.
Also adding @violatingcp and @nhanvtran to watch this.