Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing pixel features from CVS-head #7168

Closed

Conversation

clelange
Copy link
Contributor

This pull request is similar to the one for CMSSW_5_3_X here: #7167

During the switch from CVS to git a large part of the pixel code additions which are needed for the pixel online software and also calibration of the pixel detector were forgotten to be added to a release and only ended up in the CVS head. These changes should be in CMSSW_7_3_X and later (pull requests will follow for CMSSW_7_4_Y once this one is accepted).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @clelange for CMSSW_7_3_X.

added missing pixel features from CVS-head

It involves the following packages:

CalibFormats/SiPixelObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

please submit first for 74x.

@mmusich
Copy link
Contributor

mmusich commented Mar 9, 2015

@clelange #7220 is merged in 74X, what about this one?

@clelange
Copy link
Contributor Author

clelange commented Mar 9, 2015

If nobody objects, it would also be good to have it merged in 7_3_X to make sure it's propagated everywhere in the future.

@davidlange6
Copy link
Contributor

74x is the 2015 release - having this there should be sufficient

@clelange clelange deleted the pixel-updates-CMSSW_7_X_Y branch June 3, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants