Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing pixel features from CVS-head #7220

Merged
merged 1 commit into from Feb 3, 2015

Conversation

clelange
Copy link
Contributor

This pull request is the same as #7168 for CMSSW_7_3_X and is similar to the one for CMSSW_5_3_X here: #7167
David Lange asked me to first add it to CMSSW_7_4_X.

During the switch from CVS to git a large part of the pixel code additions which are needed for the pixel online software and also calibration of the pixel detector were forgotten to be added to a release and only ended up in the CVS head. These changes should be in CMSSW_7_3_X and later.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @clelange for CMSSW_7_4_X.

added missing pixel features from CVS-head

It involves the following packages:

CalibFormats/SiPixelObjects

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@clelange
Copy link
Contributor Author

clelange commented Feb 3, 2015

Hi, any reason this should not go ahead? Could you please sign this request?
Thanks,
Clemens

@mmusich
Copy link
Contributor

mmusich commented Feb 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Feb 3, 2015
added missing pixel features from CVS-head
@cmsbuild cmsbuild merged commit f52423b into cms-sw:CMSSW_7_4_X Feb 3, 2015
@clelange clelange deleted the pixel-updates-CMSSW_7_X_Y branch June 3, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants