Add support for unpacking HCAL uHTRs (Backport to 74X from PR 7950) #8103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now just check "m_flavor == 2" directly instead of checking part of the bits to see if it is 2 or 3.
This method works for flavor 2 and 4; all other flavors do not define an OK bool and so it returns 'false'.
After the header, ++ should only move 16 bits (1 row) as that is where the data starts, but after that it should move 32 bits (2 rows) as that is how each data entry is formatted.
…ld be ready to use
The L1RCTs only work with the old segmentation (version 0 for <= 2012), so if the version is anything else, we continue.
We use the tens digit in the depth field from the text file to indicate version. >= 10 is version 1, < 10 is version 0.
Previously it was hardcoded to be 0, which meant the unpacker treated everything as HO. It is now set by HcalHTRData::packHeaderTrailer. Also fix a Channel ID bug in HcalHTRData.cc
These bugs prevented HCAL Trigger Towers from properly being converted to RAW.
Previously processTrig always returned 0 because the "size" variable was set to 0, then not actually used to hold the size of the vector, and finally returned. Now size is properly set to the size of the vector.
… Very helpful when multiple sets of digis are in one file.
cmsbuild
added
alca-approved
comparison-available
dqm-approved
l1-pending
orp-pending
pending-signatures
reconstruction-approved
simulation-approved
tests-started
and removed
alca-approved
comparison-available
dqm-approved
l1-pending
orp-pending
pending-signatures
reconstruction-approved
simulation-approved
tests-rejected
labels
davidlange6
added a commit
that referenced
this pull request
Mar 10, 2015
…5-03-05-0200 Add support for unpacking HCAL uHTRs (Backport to 74X from PR 7950)
|
Hi @agude and all, |
|
Yes, I'll get those patched tonight. |
This was referenced Mar 11, 2015
This was referenced Jun 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backport of #7950 as discussed in #8013 (comment). @lihux25 said he preferred if I initiated a new pull request instead of updating #7972, so this supersedes that PR.
This pull request allows the unpacking of the uHTRs that is currently being commissioned for HCAL.
Additionally, we found various bugs in the Packing/Unpacking code that we patched: