Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of transient vector fix to CMSSW_7_2_X #8204

Merged
merged 1 commit into from Mar 31, 2015

Conversation

andrewj314
Copy link
Contributor

Backport of 7_4_X bugfix: adding ioread rules clearing transient vectors to DataFormats/TauReco/classes_def_2.xml

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_2_X.

Backport of transient vector fix to CMSSW_7_2_X

It involves the following packages:

DataFormats/TauReco

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2015

+1

for #8204 70fa716
the same change was tested and signed off in 74X #8061

@jpavel
Copy link
Contributor

jpavel commented Mar 12, 2015

Thanks Slava @andrewj314, can you prepare in similar fashion the PR's for 73x and 75x ?

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2015

Please provide a version for 73X as well

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2015

The 75X was auto-forward ported already
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/DataFormats/TauReco/src/classes_def_2.xml

@cmsbuild @ktf are the auto-forward-ports active in 73X?

@jpavel
Copy link
Contributor

jpavel commented Mar 12, 2015

good - I forgot that auto-forward is active until the 740 release is built :)

@ktf
Copy link
Contributor

ktf commented Mar 12, 2015

@slava77 nope.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants