Skip to content

vets-api/v0.0.1448

Latest
Latest
Compare
Choose a tag to compare
@va-bot va-bot released this 16 Jun 17:01
· 11345 commits to 16e68a67c69df4c280ec1c5523d96cd25f74301b since this release
vets-api/v0.0.1448
4eaeef6

Release 0.0.1448 ami-01280d03d199f6175

6235994 Mobile: Update appointments to use VAOS for local time (#12933)

  • WIP

  • Maintain mobile fallback in the event vaos does not return a local time

8da7f8a 59960 Truncate travel claim number to last4 (#12936)

First merge, here we go!

cbb1662 update cron time (#12947)

cb9d9cd Change how we represent UK addresses to BIS (#12911)

Before this PR, if the veteran provided an international_postal_code (i.e. GBR), we used an IsoCountryCodes class to automatically expand that to "United Kingdom of Great Britain and Northern Ireland", which exceeds BIS's 50 character limit for countries by two characters. No other country exceeds the 50 character limit. BIS told me that they use "United Kingdom" for the UK. This PR adds in that exception, along with some minor refactoring.

284253d Move copay notifications back to concurrent approach (#12938)

  • Move back to concurrent approach...

  • Decrease to 4 workers

e3bbdbe 5931: lighthouse letters access (#12937)

48726b2 Return nil for strange FT 500 errors (#12948)

  • return nil for strange FT case

  • rubocops

06b7066 Revert "API-27078-526-v2-allow-yyyy-mm-date-format-2 (#12927)" (#12949)

This reverts commit ae4f586.

17e3ace Bump oj from 3.14.2 to 3.15.0 (#12916)

Bumps oj from 3.14.2 to 3.15.0.

updated-dependencies:

  • dependency-name: oj
    dependency-type: direct:production
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

304aad5 Bump aws-sdk-kms from 1.63.0 to 1.66.0 (#12917)

Bumps aws-sdk-kms from 1.63.0 to 1.66.0.

updated-dependencies:

  • dependency-name: aws-sdk-kms
    dependency-type: direct:production
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

881909a Bump kms_encrypted from 1.4.0 to 1.5.0 (#12919)

Bumps kms_encrypted from 1.4.0 to 1.5.0.

updated-dependencies:

  • dependency-name: kms_encrypted
    dependency-type: direct:production
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

bc4edad API-27180-add-526-v2-getpdf-endpoint (#12913)

  • Adds /526/getPDF endpoint (GET)
  • Adds Route in routes file for the endpoint

Changes to be committed:
modified: modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
modified: modules/claims_api/config/routes.rb

2dc6ac6 Update OAS content claims v1, add swagger (#12943)

9f088aa Bump sidekiq-scheduler from 5.0.2 to 5.0.3 (#12920)

Bumps sidekiq-scheduler from 5.0.2 to 5.0.3.

updated-dependencies:

  • dependency-name: sidekiq-scheduler
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

cae9321 VA forms: Add form 21P-0847 (#12960)

  • initially generated files for 21p-0847

  • add form mappings and tests

  • rename files

  • one more name change

  • refactor multistamp methods and add tests

5e84d5e feat: Lock build to specific debian release (#12962)

  • feat: Lock build to specific debian release

  • fix: Update to support docker-compose build

Co-authored-by: Kyle A. Matheny kylematheny@protonmail.com

f1724a9 mobile - update claim request decision response (#12952)

a877c2b mobile disability rating EVSS to LH (#12934)

  • LH disability ratings

  • specs

  • specs

  • specs

  • remove doc changes

  • remove error specs

  • fix

  • fix

Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

d557682 Adds flipper feature for evss switch to bgs (#12946)

75e9736 Api 27050 request disability examples (#12931)

  • Update example.json, fix logic to handle no secondary disabilities case

  • Add rswag for updated 526 submit example

1fef9b7 Add service description for /veterans/{veteranId}/526 (#12971)

  • Updates swagger docs for dev v2
    Changes to be committed:
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb

b0716ee Update disabilityActionType enum values, add swagger (#12958)

62acab2 API-22655 526 v2 service description for validate endpoint (#12972)

  • Updates rswag_disability_compensation_request_spec for validate endpoint edscription
  • compiles docs for v2 dev
    Changes to be committed:
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb

935fbd2 API-22657 526 v2 service description for attachments (#12973)

  • Updates swagger docs for v2 dev
  • Updates routes file for updated route
    Changes to be committed:
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/config/routes.rb
    modified: modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb

4c43ff8 Api 27078 526 v2 allow yyyy mm date format 2 (#12957)

  • API-27078-526-v2-allow-yyyy-mm-date-format-2

  • Updates 526.json and related json fles to be inline with new date formats

  • Updates valdations file to handle new date formats

  • Updates validation specs t handle tests with new date formats

    • Also adds some new tests for handling new scenarios

  • Updates swagger docs
    Changes to be committed:
    modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/config/schemas/v2/526.json
    modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
    modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
    modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
    modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
    modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
    modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json

  • Merges master and updates swagger file to make sure it is inline with these changes

e41fd07 59503 add schedulable param to get_facilities (#12865)

  • add schedulable param

f1d09a5 Api 26640 establish 526 claim (#12907)

Finally got the mapper working mostly - PACT mapping still needs done, but got moved to another ticket

e67f8ec Api 26837/shared schema updates for appeals (#12961)

  • API-26837 Rename non_blank_string to nonBlankString in appeals

  • API-26837 Add Content-Language header to appeals

This is suggested in Lighthouse standards

459e31a API-27105: Reinstate Sidekiq Jobs Lost in Periodic Jobs Migration (#12969)

  • API-27105: Reinstate missing Sidekiq jobs

  • API-27105: Fix incorrect job schedule for AppealsApi::HigherLevelReviewCleanUpWeekOldPii

  • API-27105: Update job comment

  • API-27105: Disable Rubocop BlockLength check

  • API-27105: Enable Rubocop BlockLength check after disabling

93ece3e removed claims service and configuration files (#12965)

1ed6a25 Api 27356 27357 docs service and logging (#12974)

  • adds generic logging

  • return empty supporting docs if errored

  • update to error for display

dda4a7c re-add concurrent claims index (#12980)

ccdd4b9 Re-enable 1990e confirmation emails to authenticated users (#12970)

be2ac03 Fix periodic job call to VAForms::FormReloader (#12984)

3e2c8b3 Improve BGS validation error logging (#12939)

BGS sometimes returns errors containing an enormous stacktrace with an oracle error. This PR logs the oracle error message and excludes everything else. These oracle errors start with the signature ORA- and are bookended by a prepstmnt clause. See spec/fixtures/bgs/bgs_oracle_error.txt for an example. We want to log these errors separately because the original error message is so long that it obscures its only relevant information and actually breaks Sentry's UI.

b07b477 Bump fastimage from 2.2.6 to 2.2.7 (#12954)

Bumps fastimage from 2.2.6 to 2.2.7.

updated-dependencies:

  • dependency-name: fastimage
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

efc0222 Bump will_paginate from 3.3.1 to 4.0.0 (#12918)

Bumps will_paginate from 3.3.1 to 4.0.0.

updated-dependencies:

  • dependency-name: will_paginate
    dependency-type: direct:production
    update-type: version-update:semver-major
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

3c4004a Bump rswag-specs from 2.8.0 to 2.9.0 (#12955)

Bumps rswag-specs from 2.8.0 to 2.9.0.

updated-dependencies:

  • dependency-name: rswag-specs
    dependency-type: direct:development
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

d0dd386 Bump rspec-rails from 6.0.1 to 6.0.3 (#12956)

Bumps rspec-rails from 6.0.1 to 6.0.3.

updated-dependencies:

  • dependency-name: rspec-rails
    dependency-type: direct:development
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

086ca62 Bump carrierwave from 2.2.3 to 2.2.4 (#12976)

Bumps carrierwave from 2.2.3 to 2.2.4.

updated-dependencies:

  • dependency-name: carrierwave
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

c9f860a Handle special characters in names and addresses sent to BGS. (#12968)

BGS doesn't accept name and address_line fields with non-ASCII characters (e.g. , ), and doesn't accept names with apostrophes. The method introduced by this PR recursively iterates through a given hash and strips unprocessable characters from name and address_line fields. The method is called in SubmitForm686cJob and SubmitForm674Job with an enormous form payload potentially containing many names and addresses. See spec/factories/686c/form_686c_674.rb for an example of such a payload.

7466ae2 API-26351 526 v2 schema start/end date alignment (#12982)

Makes date attribute names more consistant throughout the schema.
Changes to be committed:
modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified: modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb
modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json

ea807d7 mobile - disability rating update docs and error specs (#12975)

108d98a Mobile: Update endpoint to include feature flag for flipping to lighthouse fo (#12553)

  • Update endpoint to include feature flag for flipping to lighthouse for direct deposit information

  • revert accidental changes

  • Further changes for payment updates

  • Add spec file

  • WIP

  • WIP

  • WIP

  • Final progress

  • Remove old code

  • Use shared lighthouse auth

  • Alias method for readability and update naming of memoized variable

  • Per user flipper

  • Remove unused payment_account method

  • Remove unused require

04eeb8c Bump google-protobuf from 3.23.2 to 3.23.3 (#12985)

Bumps google-protobuf from 3.23.2 to 3.23.3.

updated-dependencies:

  • dependency-name: google-protobuf
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

0009941 Bump webrick from 1.7.0 to 1.8.1 (#12986)

Bumps webrick from 1.7.0 to 1.8.1.

updated-dependencies:

  • dependency-name: webrick
    dependency-type: direct:development
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

6f81a2b Bump jwt from 2.7.0 to 2.7.1 (#12987)

Bumps jwt from 2.7.0 to 2.7.1.

updated-dependencies:

  • dependency-name: jwt
    dependency-type: direct:production
    update-type: version-update:semver-patch
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

f4f9154 Bump aws-sdk-s3 from 1.123.1 to 1.124.0 (#12989)

Bumps aws-sdk-s3 from 1.123.1 to 1.124.0.

updated-dependencies:

  • dependency-name: aws-sdk-s3
    dependency-type: direct:production
    update-type: version-update:semver-minor
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

a01113b migration to convert zipcode data type to string (#12978)

  • migration to convert zipcode data type to string

  • updated sidekiq jobs and tests for zipcode to string change

  • revert import and spec

  • temporarily skip tests

  • lint

Co-authored-by: Jeremy Weiland jeremy6d@users.noreply.github.com

767fbf5 add Luke contractor email for flipper UI (#12995)

Co-authored-by: verdanceluke luke@verdance.co

590afba API-26837 Refactor appeals fixtures (#12983)

Moves and copies JSON and PDF fixtures in the appeals_api module so that
they are specific to APIs (instead of just to PDF versions).

This is the first of several commits to update all uses of fixture
helpers throughout the appeals APIs.

88efbe3 Bump json_schemer from 0.2.24 to 1.0.2 (#12988)

Bumps json_schemer from 0.2.24 to 1.0.2.

updated-dependencies:

  • dependency-name: json_schemer
    dependency-type: direct:production
    update-type: version-update:semver-major
    ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

e86a61d API-27427-500-errors-claims-status-v2 (#12994)

  • Adds safe return with dig

  • Adds a return of an empty object in the case of a rescue due to EVSS outage

fc514eb Api 27427 500 claims status v2 404 (#12997)

  • Adds additional fault string to soap error handler

  • Adjusts error handling to account for LH claim existence

  • Removes uneeded arg

bfa091e Add error parsing for unhandled responses and update logic (#12998)

1e04dad API-27326 Fixing my overwrites (#13015)

  • Fixes the overwrite in disability_compensation_validation.rb on line 419
  • Fixes my overwrite in 526.json line 539
  • Recompiles swagger
    Changes to be committed:
    modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/config/schemas/v2/526.json

1deb266 Schedule copay notification jobs in time intervals (#12964)

  • Schedule jobs using throttle technique

  • Fix time in comment

  • spread_interval -> job_interval

  • Make comment more clear

  • Add spec for batch processing

  • Add debt related workers to codeowners

  • Remove CODEOWNERS change

5cb9a05 modify sidekiq job and tests for string zip codes (#12979)

  • modify sidekiq job and tests for string zip codes

  • lint

  • remove test skips

  • test update

  • update zip job

57d54c5 Task update classifier logging (#13013)

  • update logging message to include the classification

  • add another log msg w/ submitted_claim_id

Co-authored-by: verdanceluke luke@verdance.co

c260604 remove deceased claimant mappings as per stakeholders (#13017)

a2db1b6 Revert "59503 add schedulable param to get_facilities (#12865)" (#13016)

This reverts commit e41fd07.

0d8e317 API-26837 Clean up appeals fixture factories (#13001)

4f1aaf8 [59055] Update VHA FSR sidekiq batch callback (#13014)

  • Make callback method public

  • Move confirmation email method to user model

  • Add specs

16e68a6 4747: add get letter as json method to lighthouse letters generator s (#12990)

  • 4747: add get letter as json method to lighthouse letters generator service
Assets 2