casint 10568 disallow multiple shipping and pickup values in tsv #124
Conversation
…n be defined for each ad Changed TSV "pickup locations" column name on TSV to "pickup location" Minor updates on README
…n be defined for each ad Changed TSV "pickup locations" column name on TSV to "pickup location" Minor updates on README
README.md
Outdated
| @@ -21,6 +21,8 @@ The most popular IDEs for development have an OpenAPI plugin, which helps with v | |||
| [Here](https://plugins.jetbrains.com/plugin/14837-openapi-swagger-editor) is one for IntellJ IDEA. | |||
| Alternatively, the web [Swagger editor](https://editor.swagger.io/) can help to surface any errors quickly, but is limited to a single file. | |||
|
|
|||
| Please **make sure to resolve any linter errors and warnings** before committing changes to the main `gh-pages` branch. | |||
| Release follows standard procedure: add changes to new branch, create a PR and get required approvals, finally merge to `gh-pages`. | |||
There was a problem hiding this comment.
I'm confused, isn't this already merged here
There was a problem hiding this comment.
it was, README is merged, this is regarding a (really tiny) typo I had, check 2nd commit:
... shipping option per shipping option type (SHIP/PICKUP).'
(the trailing ')
I felt I could use this PR (as it is such a tiny change) instead of creating a new branch/PR. Maybe I should squash those 2 commits on gh-pages after merged
There was a problem hiding this comment.
ah, rebase, I see it now!
There was a problem hiding this comment.
I think you forgot make install though
There was a problem hiding this comment.
you are ABSOLUTELY correct, and I should flog myself publicly.... lesson learned (once again)...
There was a problem hiding this comment.
it happened gazillion times to everyone, it's time to automate it :)
…e_shipping_and_pickup_values_in_TSV
mario-goncalves-adevinta
dismissed
bakotaco’s stale review
The merge-base changed after approval.
|
also sorry (everyone) for taking so long, learning curve... :) |
mario-goncalves-adevinta
deleted the
mg/feature/CASINT-10568_Disallow_multiple_shipping_and_pickup_values_in_TSV
branch
minor typo