-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
casint 10568 disallow multiple shipping and pickup values in tsv #124
Merged
mario-goncalves-adevinta
merged 4 commits into
gh-pages
from
mg/feature/CASINT-10568_Disallow_multiple_shipping_and_pickup_values_in_TSV
Mar 1, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
060b0b3
changed examples and docs to reflect that only 1 SHIP and 1 PICKUP ca…
mario-goncalves-adevinta af85f80
changed examples and docs to reflect that only 1 SHIP and 1 PICKUP ca…
mario-goncalves-adevinta d1b7388
Merge branch 'gh-pages' into mg/feature/CASINT-10568_Disallow_multipl…
mario-goncalves-adevinta 0367ed7
minor typo on README (and now with make install as well, lesson learned)
mario-goncalves-adevinta File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
doc/0.129/_downloads/93dbf90792498ee82059295c17c481bd/feed-example.tsv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
vendor id title description status category id google product category product type url vanity url image link additional image link condition price type price original price unit pricing measure unit pricing base measure gtin brand mpn item group id phone number email advertiser seller name region id micro tip total budget daily budget cpc autobid pickup locations shipping attributes material color gender age group size energy efficiency class min energy efficiency class max energy efficiency class | ||
42 Bally 1992 Adams Family Best pinball machine ever made ACTIVE 1624 Electronics > Arcade Equipment > Pinball Machines Hobby & Games > Arcade Games > Pinball Machines https://pinball.com/game/bally-adams-family/ https://pinball.com https://pinball.com/game/bally-adams-family/1.jpg https://pinball.com/game/bally-adams-family/2.jpg,https://pinball.com/game/bally-adams-family/3.jpg refurbished FIXED_PRICE 870000 875000 938452789055 Bally BC23456 16123456789 TRUE Pinball King 10000 1000 TRUE 1097DN 695:2d-5d;1195:1d-2d model:Adams Family,multiball:TRUE,screen size:32",resolutions:"1024x768:24dpi,800x600:18dpi" Wood/Metal/Glass black/white/green unisex adult E F D | ||
vendor id title description status category id google product category product type url vanity url image link additional image link condition price type price original price unit pricing measure unit pricing base measure gtin brand mpn item group id phone number email advertiser seller name region id micro tip total budget daily budget cpc autobid pickup location shipping attributes material color gender age group size energy efficiency class min energy efficiency class max energy efficiency class | ||
42 Bally 1992 Adams Family Best pinball machine ever made ACTIVE 1624 Electronics > Arcade Equipment > Pinball Machines Hobby & Games > Arcade Games > Pinball Machines https://pinball.com/game/bally-adams-family/ https://pinball.com https://pinball.com/game/bally-adams-family/1.jpg https://pinball.com/game/bally-adams-family/2.jpg,https://pinball.com/game/bally-adams-family/3.jpg refurbished FIXED_PRICE 870000 875000 938452789055 Bally BC23456 16123456789 TRUE Pinball King 10000 1000 TRUE 1097DN 695:2d-5d model:Adams Family,multiball:TRUE,screen size:32",resolutions:"1024x768:24dpi,800x600:18dpi" Wood/Metal/Glass black/white/green unisex adult E F D |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
doc/next/_downloads/93dbf90792498ee82059295c17c481bd/feed-example.tsv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
vendor id title description status category id google product category product type url vanity url image link additional image link condition price type price original price unit pricing measure unit pricing base measure gtin brand mpn item group id phone number email advertiser seller name region id micro tip total budget daily budget cpc autobid pickup locations shipping attributes material color gender age group size energy efficiency class min energy efficiency class max energy efficiency class | ||
42 Bally 1992 Adams Family Best pinball machine ever made ACTIVE 1624 Electronics > Arcade Equipment > Pinball Machines Hobby & Games > Arcade Games > Pinball Machines https://pinball.com/game/bally-adams-family/ https://pinball.com https://pinball.com/game/bally-adams-family/1.jpg https://pinball.com/game/bally-adams-family/2.jpg,https://pinball.com/game/bally-adams-family/3.jpg refurbished FIXED_PRICE 870000 875000 938452789055 Bally BC23456 16123456789 TRUE Pinball King 10000 1000 TRUE 1097DN 695:2d-5d;1195:1d-2d model:Adams Family,multiball:TRUE,screen size:32",resolutions:"1024x768:24dpi,800x600:18dpi" Wood/Metal/Glass black/white/green unisex adult E F D | ||
vendor id title description status category id google product category product type url vanity url image link additional image link condition price type price original price unit pricing measure unit pricing base measure gtin brand mpn item group id phone number email advertiser seller name region id micro tip total budget daily budget cpc autobid pickup location shipping attributes material color gender age group size energy efficiency class min energy efficiency class max energy efficiency class | ||
42 Bally 1992 Adams Family Best pinball machine ever made ACTIVE 1624 Electronics > Arcade Equipment > Pinball Machines Hobby & Games > Arcade Games > Pinball Machines https://pinball.com/game/bally-adams-family/ https://pinball.com https://pinball.com/game/bally-adams-family/1.jpg https://pinball.com/game/bally-adams-family/2.jpg,https://pinball.com/game/bally-adams-family/3.jpg refurbished FIXED_PRICE 870000 875000 938452789055 Bally BC23456 16123456789 TRUE Pinball King 10000 1000 TRUE 1097DN 695:2d-5d model:Adams Family,multiball:TRUE,screen size:32",resolutions:"1024x768:24dpi,800x600:18dpi" Wood/Metal/Glass black/white/green unisex adult E F D |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, isn't this already merged here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was, README is merged, this is regarding a (really tiny) typo I had, check 2nd commit:
... shipping option per shipping option type (SHIP/PICKUP).'
(the trailing ')
I felt I could use this PR (as it is such a tiny change) instead of creating a new branch/PR. Maybe I should squash those 2 commits on gh-pages after merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, rebase, I see it now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot make install though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are ABSOLUTELY correct, and I should flog myself publicly.... lesson learned (once again)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it happened gazillion times to everyone, it's time to automate it :)