[EuiDatePicker][a11y] Fix screen reader announcements on time selection and intermittently broken up/down navigation on NVDA/JAWS #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Copenut
reviewed
May 2, 2024
- should be on the parent element that *does not* dynamically change - also needs a polite attribute! yikes
- trying to fix the issue where the up/down arrow keys don't work - not sure if this is doing anything honestly, need Trevor to test on staging
This reverts commit ae2b782.
cee-chen
force-pushed
the
datepicker/nvda-jaws-timepicker-fix
branch
from
1274c3a
to
03949be
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
1Copenut
approved these changes
May 16, 2024
There was a problem hiding this comment.
💯 This change is a major improvement in the screen reader UX for EuiDatePicker and EuiSuperDatePicker.
I tested the behavior and confirmed it's working as expected using the following screen reader / browser combos:
- MacOS Safari + VoiceOver
- Win10 Firefox + NVDA
- Win10 Chrome + NVDA
- Win10 Chrome + JAWS
This testing and pair-coding did identify a bug (in prod already) how the EuiSuperDatePicker is handling time picking for screen readers. I'll log a separate issue for that so we don't block this PR with an out-of-scope item.
mgadewoll
added a commit
to elastic/kibana
that referenced
this pull request
May 22, 2024
`v94.5.0-backport.1` ⏩ `v94.5.1` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v94.5.1`](https://github.com/elastic/eui/releases/v94.5.1) **Bug fixes** - Fixed an `EuiDualRange`s with `showInput` bug, where `min`/`max` values and invalid states were not being correctly set if values were empty strings ([#7767](elastic/eui#7767)) **Accessibility** - Improved `EuiDatePicker` and `EuiSuperDatePicker`'s time selection screen reader UX ([#7726](elastic/eui#7726)) - Improved the accessibility of `EuiDatePicker` by providing full screen-reader-only week day names to the calendar header ([#7748](elastic/eui#7748)) - Improved `EuiBadge`'s ability to tell when text within the badge is selected/highlighted and selection color contrast ([#7752](elastic/eui#7752))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #6687
QA
General checklist
- [ ] Added or updated jest and cypress tests