[EuiDualRange] Fix incorrect input min/max values when empty string values exist #7767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7764
Number('')
evals to0
which is why the bug was happening. The new code checks forvalue === ''
and more manually falls back to the min/max if so. Sadly we can't DRY this out in the getter because the getter is used too many other places / we do actually need to render''
for the value.Added a unit regression test to check for the correct applied
min
/max
props when values are empty strings.QA
General checklist
NaN
for empty inputs which is the same as productionor updatedjestand cypresstests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)