[EuiDualRange] Fix incorrect input min/max values when empty string values exist #7767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Number('')` evals to `0` which is why the bug was previously happening
cee-chen
changed the title
cee-chen
changed the title
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
1Copenut
approved these changes
May 16, 2024
|
Thanks Trevor! |
mgadewoll
added a commit
to elastic/kibana
that referenced
this pull request
May 22, 2024
`v94.5.0-backport.1` ⏩ `v94.5.1` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v94.5.1`](https://github.com/elastic/eui/releases/v94.5.1) **Bug fixes** - Fixed an `EuiDualRange`s with `showInput` bug, where `min`/`max` values and invalid states were not being correctly set if values were empty strings ([#7767](elastic/eui#7767)) **Accessibility** - Improved `EuiDatePicker` and `EuiSuperDatePicker`'s time selection screen reader UX ([#7726](elastic/eui#7726)) - Improved the accessibility of `EuiDatePicker` by providing full screen-reader-only week day names to the calendar header ([#7748](elastic/eui#7748)) - Improved `EuiBadge`'s ability to tell when text within the badge is selected/highlighted and selection color contrast ([#7752](elastic/eui#7752))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7764
Number('')evals to0which is why the bug was happening. The new code checks forvalue === ''and more manually falls back to the min/max if so. Sadly we can't DRY this out in the getter because the getter is used too many other places / we do actually need to render''for the value.Added a unit regression test to check for the correct applied
min/maxprops when values are empty strings.QA
General checklist
NaNfor empty inputs which is the same as productionor updatedjestand cypresstests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)