Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uneventful.js.org #8992

Merged
merged 1 commit into from May 5, 2024
Merged

uneventful.js.org #8992

merged 1 commit into from May 5, 2024

Conversation

pjeby
Copy link
Contributor

@pjeby pjeby commented May 4, 2024

@pjeby
Copy link
Contributor Author

pjeby commented May 4, 2024

I just noticed that it's not possible to see the generated docs on the github.io/ version after I set the CNAME... so FYI it's a typedoc-generated API reference site for https://github.com/pjeby/uneventful/

@MattIPv4 MattIPv4 changed the title Add uneventful.js.org uneventful.js.org May 5, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/pjeby/uneventful

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels May 5, 2024
@indus
Copy link
Member

indus commented May 5, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@indus indus added error The page requested returns an error and removed error The page requested returns an error labels May 5, 2024
@indus
Copy link
Member

indus commented May 5, 2024

Welcome https://uneventful.js.org

@pjeby
Copy link
Contributor Author

pjeby commented May 5, 2024

Done - it appears to be working now. Simply setting to use the /docs directory in settings, then back again, and force-pushing the branch back how it was seems to suffice. It's up and live now.

@indus indus merged commit d9e47a9 into js-org:master May 5, 2024
1 check passed
@pjeby pjeby deleted the patch-1 branch May 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants