Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gterminal.js.org #8532

Merged
merged 4 commits into from
Sep 24, 2023
Merged

gterminal.js.org #8532

merged 4 commits into from
Sep 24, 2023

Conversation

Cameo007
Copy link
Contributor

https://gterminal-project.github.io/

@indus indus changed the title Update cnames_active.js gterminal.js.org Sep 22, 2023
@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 22, 2023
@indus
Copy link
Member

indus commented Sep 22, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line gterminal.js.org to make it work. (you can't have two custom domains for one repo)
I'll merge after we have "contact". Please keep this PR open.

@indus
Copy link
Member

indus commented Sep 22, 2023

Oh and you have to fix your Pull Request by adding a , in the end of your lin. See the CI error: https://github.com/js-org/js.org/actions/runs/6274818804/job/17041321646?pr=8532

@Cameo007
Copy link
Contributor Author

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line gterminal.js.org to make it work. (you can't have two custom domains for one repo) I'll merge after we have "contact". Please keep this PR open.

Thanks. My Github Pages deployment failed. I'll check it.

@Cameo007
Copy link
Contributor Author

Done.

@indus
Copy link
Member

indus commented Sep 23, 2023

@Cameo007 but it does not yet work: https://gterminal.js.org
In case you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@Cameo007
Copy link
Contributor Author

I forgot to change the domain name in the gh Pages settings.

@indus
Copy link
Member

indus commented Sep 23, 2023

As you may have noticed by checking the domain there is still an issue: The page isn’t redirecting properly. You may have to contact the GitHub support if you are unable to fix the issue.

@Cameo007
Copy link
Contributor Author

Now it should really work.

@J0J0HA
Copy link

J0J0HA commented Sep 24, 2023

As you may have noticed by checking the domain there is still an issue: The page isn’t redirecting properly. You may have to contact the GitHub support if you are unable to fix the issue.

If this problem occurs in the future, our solution was:

  1. Setting the deploy method to "Deploy from branch"
  2. Manually triggering the workflow (for us via workflow_dispatch)
  3. Setting the deploy method back to "GitHub Actions"

Maybe it was only the manual trigger, but at least it works now :)

@indus indus added add This PR/issue is regarding adding a new subdomain and removed add This PR/issue is regarding adding a new subdomain awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 24, 2023
@indus
Copy link
Member

indus commented Sep 24, 2023

Welcome https://gterminal.js.org

@indus indus merged commit d4e35a3 into js-org:master Sep 24, 2023
1 check passed
@Cameo007 Cameo007 deleted the patch-1 branch September 24, 2023 15:47
This was referenced Sep 30, 2023
This was referenced Oct 11, 2023
This was referenced Oct 25, 2023
@indus indus mentioned this pull request Nov 12, 2023
2 tasks
This was referenced Nov 14, 2023
This was referenced Nov 24, 2023
@indus indus mentioned this pull request Jan 12, 2024
This was referenced Jan 29, 2024
This was referenced Feb 22, 2024
This was referenced Mar 2, 2024
@indus indus mentioned this pull request Mar 12, 2024
2 tasks
@indus indus mentioned this pull request Mar 21, 2024
2 tasks
This was referenced Apr 5, 2024
This was referenced May 1, 2024
@indus indus mentioned this pull request May 13, 2024
2 tasks
@indus indus mentioned this pull request Jun 24, 2024
2 tasks
@indus indus mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants