Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-next.js.org #7853

Merged
merged 1 commit into from
Dec 5, 2022
Merged

open-next.js.org #7853

merged 1 commit into from
Dec 5, 2022

Conversation

jayair
Copy link
Contributor

@jayair jayair commented Dec 2, 2022

@MattIPv4 MattIPv4 changed the title Adding request for open-next.js.org open-next.js.org Dec 3, 2022
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance open-next.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Dec 3, 2022
@jayair
Copy link
Contributor Author

jayair commented Dec 3, 2022

Oops! Fixed.

@indus
Copy link
Member

indus commented Dec 3, 2022

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line alova.js.org to make it work. As you are using a workflow to deploy the page there may be other steps involved.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account labels Dec 3, 2022
@jayair
Copy link
Contributor Author

jayair commented Dec 4, 2022

@indus Oh does changing it through the UI help btw?

Screen Shot 2022-12-03 at 7 03 53 PM

@indus
Copy link
Member

indus commented Dec 4, 2022 via email

@indus
Copy link
Member

indus commented Dec 4, 2022

Just tested - no I'm getting 404 again: https://open-next.js.org
Maybe this is some help: #7666 (comment)

@jayair
Copy link
Contributor Author

jayair commented Dec 4, 2022

@indus yeah I tried that too and I think it works!

For anybody that comes across this. I think you need to do the default GitHub pages deployment with the custom domain set. That gets it setup. You can then flip it back to the GitHub actions deployment.

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Dec 5, 2022
@indus
Copy link
Member

indus commented Dec 5, 2022

Welcome https://open-next.js.org

Thanks for the hints on how to solve this.

@indus indus merged commit 2bd4876 into js-org:master Dec 5, 2022
@jayair jayair deleted the patch-1 branch December 5, 2022 18:14
@indus indus mentioned this pull request Dec 8, 2022
2 tasks
@indus indus mentioned this pull request Jan 11, 2023
3 tasks
@indus indus mentioned this pull request Feb 25, 2023
2 tasks
@indus indus mentioned this pull request Mar 13, 2023
2 tasks
@indus indus mentioned this pull request Mar 29, 2023
2 tasks
This was referenced Apr 13, 2023
This was referenced May 5, 2023
@indus indus mentioned this pull request Jul 1, 2023
2 tasks
This was referenced Jul 11, 2023
@indus indus mentioned this pull request Aug 1, 2023
2 tasks
This was referenced Nov 14, 2023
This was referenced Nov 24, 2023
@indus indus mentioned this pull request Jan 12, 2024
This was referenced Jan 29, 2024
This was referenced Feb 22, 2024
This was referenced Mar 2, 2024
@indus indus mentioned this pull request Mar 12, 2024
2 tasks
@indus indus mentioned this pull request Mar 21, 2024
2 tasks
This was referenced Apr 5, 2024
This was referenced May 1, 2024
@indus indus mentioned this pull request May 13, 2024
2 tasks
@indus indus mentioned this pull request Jun 24, 2024
2 tasks
@indus indus mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants