New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hold] Runtimeclass API #67049
[hold] Runtimeclass API #67049
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tallclair If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@tallclair: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
// +optional | ||
metav1.ListMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"` | ||
|
||
// Items is a list of schema objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items is a list of RuntimeClass
?
/cc |
@tallclair: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing to separate pod changes & new API. |
Adds (but doesn't implement) the RuntimeClass API proposed in https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md
For kubernetes/enhancements#585
Special notes for your reviewer:
Release note:
/sig node
/kind api-change
/priority important-soon
/milestone v1.12