Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/concepts_workloads_controllers/deployment_and_gc #14850

Merged
merged 3 commits into from Jun 29, 2020
Merged

Add content/es/docs/concepts_workloads_controllers/deployment_and_gc #14850

merged 3 commits into from Jun 29, 2020

Conversation

emedina
Copy link
Contributor

@emedina emedina commented Jun 12, 2019

Spanish Translation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 12, 2019
@emedina emedina force-pushed the es/docs/concepts_workloads_controllers/deployment_and_gc branch from 42068f9 to e050dc6 Compare June 12, 2019 14:53
@netlify
Copy link

netlify bot commented Jun 12, 2019 •
edited

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 972c95c

https://deploy-preview-14850--kubernetes-io-master-staging.netlify.app

@raelga raelga self-assigned this Jun 15, 2019
@raelga raelga changed the title Spanish Translation Add content/es/docs/concepts_workloads_controllers/deployment_and_gc Jun 15, 2019
@raelga
Copy link
Member

raelga commented Jun 15, 2019

Thanks! Tracked at #13948.

@raelga raelga mentioned this pull request Jul 27, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2019
@emedina
Copy link
Contributor Author

emedina commented Sep 13, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2019
electrocucaracha
electrocucaracha reviewed Sep 27, 2019
View reviewed changes
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
@emedina emedina force-pushed the es/docs/concepts_workloads_controllers/deployment_and_gc branch from e050dc6 to 4f1294d Compare September 30, 2019 11:09
emedina
emedina commented Sep 30, 2019
View reviewed changes
Copy link
Contributor Author

@emedina emedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electrocucaracha Todas las revisiones resueltas.

@raelga
Copy link
Member

raelga commented Oct 3, 2019

Muchas gracias @emedina como siempre :)

¿Puedes validar los cambios de tu revisión @electrocucaracha?

:)

@emedina emedina force-pushed the es/docs/concepts_workloads_controllers/deployment_and_gc branch from 4f1294d to 99e9ab9 Compare October 7, 2019 12:29
@emedina
Copy link
Contributor Author

emedina commented Oct 7, 2019

@electrocucaracha Cambios realizados. Revisa ahora.

electrocucaracha
electrocucaracha reviewed Oct 14, 2019
View reviewed changes
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/garbage-collection.md Outdated Show resolved Hide resolved
@emedina emedina force-pushed the es/docs/concepts_workloads_controllers/deployment_and_gc branch from 99e9ab9 to eab4f21 Compare October 15, 2019 05:41
@emedina
Copy link
Contributor Author

emedina commented Oct 15, 2019

@electrocucaracha Todo arreglado/cambiado.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2020
@electrocucaracha
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2020
@electrocucaracha
Copy link
Contributor

/lgtm

/cc @raelga

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@kbhawkey
Copy link
Contributor

@emedina , Checking if you are actively working on this pull request? This PR has been open for a very long time.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@emedina
Copy link
Contributor Author

emedina commented May 13, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2020
raelga
raelga requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchísimas gracias como siempre @emedina y siento mucho la demora, más de un año.

La documentación es estupenda, solo te hecho algunas sugerencias de palabras / conceptos que o bien no se deberían traducir, o en todo caso, hacer traducciones menos literales. A ver qué te parece!

content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
content/es/docs/concepts/workloads/controllers/deployment.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2020
@emedina
Copy link
Contributor Author

emedina commented Jun 26, 2020 •
edited

@raelga Cambios subidos.

@raelga
Copy link
Member

raelga commented Jun 27, 2020 •
edited

Muchas gracias @emedina, pero te has dejado alguno de los comentarios. ¿Puedes echarle un vistazo?

Algunas son propuestas que no hace falta aplicar, pero algunas son errores tipográficos. ¿Le puedes dar un repaso? Es posible que no lo hayas visto porque cuando hay muchos comentarios, el acordeón se repliega y solo muestra los primeros y últimosss.

image

Si no estás de acuerdo con alguno de los cambios, no hay problema, deja un comentario y resuelve la conversación.

@emedina
Merge branch 'master' of https://github.com/kubernetes/website into e…
972c95c 
…s/docs/concepts_workloads_controllers/deployment_and_gc
@emedina
Copy link
Contributor Author

emedina commented Jun 29, 2020

@raelga Cambios pendientes subidos.

raelga
raelga approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genial @emedina, muchas gracias!

Hay algún problema con alguna de tus aportaciones, que no se cargan en la web Kubernetes.io.

Mergeamos esta PR ya que el contenido está perfecto, y luego abro una para revisar que está pasando, puede ser por el nuevo tema.

Muchas gracias como siempre!

@raelga
Copy link
Member

raelga commented Jun 29, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit a911fca into kubernetes:master Jun 29, 2020
@raelga
Copy link
Member

raelga commented Jun 29, 2020

Issue to review the missing pages: #22168

@emedina emedina mentioned this pull request Jul 6, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@electrocucaracha electrocucaracha electrocucaracha left review comments

@sftim sftim sftim left review comments

@alexbrand alexbrand Awaiting requested review from alexbrand

Assignees

@raelga raelga

@electrocucaracha electrocucaracha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@emedina @raelga @fejta-bot @electrocucaracha @kbhawkey @k8s-ci-robot @sftim