Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing capture statements #21359

Merged
merged 21 commits into from Jun 10, 2020

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented May 30, 2020

Generating pages without capture statements.
Completed de, en, es, fr, id, it, ja, ko, pl, pt, ru, uk, vi, zh.
Removed related capture template code.
Created contribute/style/page-content-types.md
Previous testing PRs (#20977, #21253, #21277).

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 30, 2020
@k8s-ci-robot k8s-ci-robot requested review from aanm and ahg-g May 30, 2020 19:56
@netlify
Copy link

netlify bot commented May 30, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 87f6871

https://deploy-preview-21359--kubernetes-io-master-staging.netlify.app

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language labels Jun 1, 2020
@sftim
Copy link
Contributor

sftim commented Jun 2, 2020

@kbhawkey I spotted a detail about section ordering

Compare
https://kubernetes.io/docs/tasks/tools/install-minikube/
https://deploy-preview-21359--kubernetes-io-master-staging.netlify.app/docs/tasks/tools/install-minikube/

also

https://kubernetes.io/fr/docs/tasks/tools/install-minikube/
https://deploy-preview-21359--kubernetes-io-master-staging.netlify.app/fr/docs/tasks/tools/install-minikube/

and look at the What's next section ordering. The conversion is not placing the What's next “capture” last in the page.

(I think this is enough to go on with; if the explanation isn't clear, I'm happy to provide screenshots / further examples).

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jun 2, 2020

@kbhawkey I spotted a detail about section ordering

Compare
https://kubernetes.io/docs/tasks/tools/install-minikube/
https://deploy-preview-21359--kubernetes-io-master-staging.netlify.app/docs/tasks/tools/install-minikube/

also

https://kubernetes.io/fr/docs/tasks/tools/install-minikube/
https://deploy-preview-21359--kubernetes-io-master-staging.netlify.app/fr/docs/tasks/tools/install-minikube/

and look at the What's next section ordering. The conversion is not placing the What's next “capture” last in the page.

(I think this is enough to go on with; if the explanation isn't clear, I'm happy to provide screenshots / further examples).

Thanks @sftim. The install-minikube page has one H1 heading and the what's next heading is not the last heading in the Markdown page.
The migration script did not move the headings. I can correct the order of the headings in the page and change the H1 heading to H2.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 2, 2020
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jun 10, 2020

I just noticed that the generated component tool pages (en only) did not convert the front matter
variable. I made a typo in the script (searched for tool_reference instead of tool-reference).
The headings were converted. I will fix these pages.
docs/reference/command-line-tools-reference/kubelet/
docs/reference/command-line-tools-reference/cloud-controller-manager/
docs/reference/command-line-tools-reference/kube-apiserver/
docs/reference/command-line-tools-reference/kube-controller-manager/
docs/reference/command-line-tools-reference/kube-proxy/
docs/reference/command-line-tools-reference/kube-scheduler/
docs/reference/kubectl/kubectl/

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@tengqm
Copy link
Contributor

tengqm commented Jun 10, 2020

this is HUGE!!!
Given the necessity of the change made, I'd vote for kicking this in earlier than later.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@sftim
Copy link
Contributor

sftim commented Jun 10, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 15f44cc into kubernetes:master Jun 10, 2020
@sftim
Copy link
Contributor

sftim commented Jun 10, 2020

This addresses several problems identified in issue #20335

@kbhawkey kbhawkey deleted the kb-migrate-capture-stmts branch July 30, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants