Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Default to an empty string when validating the signature hash query parameter #23721

Merged
merged 1 commit into from Mar 28, 2018
Merged

[5.6] Default to an empty string when validating the signature hash query parameter #23721

merged 1 commit into from Mar 28, 2018

Conversation

hmazter
Copy link
Contributor

@hmazter hmazter commented Mar 28, 2018

This PR is a follow up to #23618 fixing the problem explained in #23618 (comment)

When validating a signature and the signature query param is not present in the request, hash_equals will throw an ErrorException since it expects a string to compare but $request->query('signature') will return null

@taylorotwell taylorotwell merged commit 30d2f7f into laravel:5.6 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants