Fixed hatch clipping. #2003
Merged
Fixed hatch clipping. #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks good. I'll merge once Travis has had a chance to do its thing. |
Don't overwrite unit_circle vertices in clipping test
| points = [(0.5,0.5), (1.5,0.5)] | ||
|
|
||
| assert np.all(path.contains_points(points) == [True, False]) | ||
|
|
||
|
|
||
| @image_comparison(baseline_images=["clip_path_clipping"], remove_text=True) | ||
| def test_clipping(): | ||
| exterior = mpath.Path.unit_rectangle() |
There was a problem hiding this comment.
This is against v1.2.x where #2010 is against master. I think it needs to be the other way around...
There was a problem hiding this comment.
Indeed. So we can merge this, merge #2010, merge 1.2.x over to master, and then make my suggested change as part of that. (It doesn't really matter, but that feels like the path of least resistance...)
|
@mdboom - I don't think there is anything left for me to do in this PR. Is it good for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2001