New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: more windows build and CI changes #5629
Conversation
@pelson: Could you comment on this:
-> Why not use the documented way with |
Thanks @JanSchulz. I've responded in #5604 (comment). Essentially, if we do it the latter way, we are able to do things like |
I would suggest a healthier choice would be to look at extending conda-forge to include functools32. I'm happy to support you in doing this (see https://github.com/conda-forge/staged-recipes). In general, anything that involves a single-user anaconda.org channel should be avoided, IMHO. |
Yes, true. PR submitted... |
@JanSchulz state of this? |
on it during the next hours on the train... |
@pelson I tried your way, but it doesn't work for multiple reasons:
First, The second reason is that matplotlibs setup call is protected by a
I've asked for a new way to get the version directly from versioneer: conda/conda-build#714 [update: there won't be such a change, so I can't see a way to replace the current version overwrite with a template one. @pelson if you have an idea how to fix this, that would be great...] |
Current status: I want to have a look how to compile with a local freetype version, so that the tests can run (and afterwards enable the tests again). But other than this, I'm happy with the PR... |
Since FT 2.6 it uses ctypes and is easly build if the compiler is already set up, |
Ok, I looked into the freetype building stuff ( From there it's almost easier/cleaner to include the complete source of that repo (adjusted to download the included sources (tars/zips) instead of using checked in ones...). @tacaswell @mdboom Any preference: just include the minimal source to compile the downloaded freetype or include the complete utils.py and let it compile everything which isn't found on the (windows-)system? The first will mean that I inline all relevant helper functions from utils.py and refatcor the local_freetype path in setupext.py to swithc between *ix (current codepath) and windows (utils.py stuff). If the latter, it would mean that each dependency would gain a "local_whatever" switch and a
and in setup_local_build.py:
|
I think I prefer the latter. Seems better organized. |
@mdboom Had a closer look and it seems that this would also need fixes for most other parts of the individual tests (e.g. |
e6984f7
to
125a0cd
Compare
Got the "local freetype" build going... |
1152e36
to
34af88a
Compare
Looks like the current problem is that |
Ok, the current problem looks like we need to clean the build area before starting the conda build... tomorrow... |
I'm a bit perplexed:
Why "version a"? https://github.com/numpy/numpy/blob/master/numpy/core/code_generators/generate_numpy_api.py#L91 |
Numpy ABI versions don't have a 1-to-1 correspondance with Numpy versions. And the code is displaying the number in hexadecimal so My guess here is that the build is not being entirely cleaned before being rebuilt for a different numpy version. EDIT: Oh, and I see you already said that... |
0e4efd4
to
63db4de
Compare
@pelson: Ok, new hypothesis: the things we set in The biggest difference is that there is a difference what is run when: normal build:
conda build:
This is what is called by the bld.bat (after conda build adds it's own commands to the start):
If this hypothesis is right, then including the old variables in the new set will let the build succeed... Lets see... |
And yay, it seems to work. @pelson you might want to implement something similar to jankatins@63db4de [edit: or not, not the 3.4 64bit build gets a 32bit 2.7 python?] |
8d6a489
to
52e4d9e
Compare
Conda prefers the normal VS tools for py27 instead of the python specific ones and appeveyor has no 64bit versions installed there. Same for the py34 version of VS, which lacks the vcvars64.bat "hack": point 4 in http://blog.ionelmc.ro/2014/12/21/compiling-python-extensions-on-windows/#for-python-3-4 Also fix some environtment variable leaks from the test environment to the conda build environment. Also fix the build error on 64bit builds
Ok the 3.4 build is hopefully fixed by using I enabled the tests (still not failing, only showing...) and the wheel build again, lets see how this works... |
Yay, green... |
Ok, this is now green but the tests still fail (and are silenced to let the build continue). Not sure how to proceed here. IMO the best is to merge and then handle the test failure in a different PR (e.g. #5748)? There is also the case that some image comparison tools are missing (GS,...), so only 1 of the 3 tests per image are run. There are currently no conda packages for these tools, so this needs tooling support in other parts of the community :-/ |
This is great progress and I fully support merging it now and improve further in a new PR. |
WIP: more windows build and CI changes
🍻 |
Yes, thanks @JanSchulz. This is tiresome work with long feedback loops. But really worthwhile, given the imbalance between users on Windows and developers on Windows. |
Followup after #5604
local_freetype = True
insetup.cfg
to get image comparison tests? Probably needs windows fixes in the setup code? yep: Fix #5519: Patch now support the 'None' linestyle #5696 (comment)Closes: #5627