Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5519: Patch now support the 'None' linestyle #5696

Closed
wants to merge 1 commit into from
Closed

Fix #5519: Patch now support the 'None' linestyle #5696

wants to merge 1 commit into from

Conversation

Rezangyal
Copy link
Contributor

If patch.linestyle is 'none', 'None', ' ', '' or None then no edge rendered (as in Line2D).
This fix #5519.

If patch.linestyle  is "none", "None", " ", "" or None then no edge
rendered (as in Line2D).
gc.set_linewidth(lw)
gc.set_linestyle(self._linestyle)
if (self._edgecolor[3] == 0 or
self._linestyle in {'none', 'None', ' ', '', None}):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include None in this check. We reserve None to mean 'do the default thing' not 'do nothing'.

@tacaswell
Copy link
Member

Can you also add a test (see http://matplotlib.org/devel/testing.html#writing-an-image-comparison-test + look at other tests in the test suite for how to do this)?

@Rezangyal
Copy link
Contributor Author

ok, tomorrow.

@tacaswell
Copy link
Member

@Rezangyal Can you please re-open this against the v2.x branch? There was a mistake on our side that needed to be fixed which required deleting the v2.0.x branch.

@Rezangyal
Copy link
Contributor Author

I create a new branch (https://github.com/Rezangyal/matplotlib/tree/fix_linestyle_none),
but the test is not working to me.
When I set local_freetype = True in setup.cfg I receive an error message:

running build_ext
Building freetype-2.6.1.tar.gz
'"CFLAGS=\"' is not recognized as an internal or external command, operable program or batch file.
Traceback (most recent call last):
  File "setup.py", line 290, in <module>
    **extra_args
...
  File "setup.py", line 144, in run
    package.do_custom_build()
  File "x:\git\matplotlib\setupext.py", line 1000, in do_custom_build
    '--with-png=no --with-harfbuzz=no'], shell=True, cwd=src_path)
  File "x:\Python27\lib\subprocess.py", line 511, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['CFLAGS=" -fPIC" ./configure --with-zlib=no --with-bzip2=no --with-png=no --with-harfbuzz=no']' returned non-zero exit status 1

(python27 32bit, windows8.1)
maybe the 'set' is missing from command line

@mdboom
Copy link
Member

mdboom commented Dec 22, 2015

When I set local_freetype = True in setup.cfg I receive an error message:

Sorry, I think that feature isn't yet working on Windows. @JanSchulz: can you confirm that, or should that be working?

@jankatins
Copy link
Contributor

I haven't tried the internal freetype yet. There is a todo in #5629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants