New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5519: Patch now support the 'None' linestyle #5696
Conversation
If patch.linestyle is "none", "None", " ", "" or None then no edge rendered (as in Line2D).
gc.set_linewidth(lw) | ||
gc.set_linestyle(self._linestyle) | ||
if (self._edgecolor[3] == 0 or | ||
self._linestyle in {'none', 'None', ' ', '', None}): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not include None
in this check. We reserve None
to mean 'do the default thing' not 'do nothing'.
Can you also add a test (see http://matplotlib.org/devel/testing.html#writing-an-image-comparison-test + look at other tests in the test suite for how to do this)? |
ok, tomorrow. |
@Rezangyal Can you please re-open this against the v2.x branch? There was a mistake on our side that needed to be fixed which required deleting the v2.0.x branch. |
I create a new branch (https://github.com/Rezangyal/matplotlib/tree/fix_linestyle_none),
(python27 32bit, windows8.1) |
Sorry, I think that feature isn't yet working on Windows. @JanSchulz: can you confirm that, or should that be working? |
I haven't tried the internal freetype yet. There is a todo in #5629 |
If patch.linestyle is 'none', 'None', ' ', '' or None then no edge rendered (as in Line2D).
This fix #5519.