Launch/Open/GoTo: Userfacing strings #32519
Conversation
| value : The object must be serialized into a byte array | ||
| : using a System.ComponentModel.TypeConverter | ||
| : and then encoded with base64 encoding. | ||
| --> |
There was a problem hiding this comment.
Why add all these comments?
There was a problem hiding this comment.
That's all done auto by Visual Studio.
There was a problem hiding this comment.
P.S. Using resW versus resX is a different and larger topic
| @@ -89,7 +148,7 @@ | |||
| <value>This setting has been disabled by your administrator.</value> | |||
| </data> | |||
| <data name="STARTUP_DISABLED_BY_USER" xml:space="preserve"> | |||
| <value>This setting has been disabled manually via <a href="https://ms_settings_startupapps" target="_blank">Startup Settings</a>.</value> | |||
| <value>This setting has been disabled manually via <a href="https://ms_settings_startupapps" target="_blank">Startup Settings</a>.</value> | |||
There was a problem hiding this comment.
Is this change working? Looks like unneeded change with the context of the PR.
There was a problem hiding this comment.
That's all done auto by Visual Studio.
There was a problem hiding this comment.
this needs to be validated it works if it was changed.
There was a problem hiding this comment.
@jaimecbernardo @crutkas If I interpret this result correctly, this string isn't even used anywhere. Does that answer your questions? 😆
There was a problem hiding this comment.
As it has a href, this is legacy then from the react style app that never got refactored out when that subsystem was removed
|
Thanks for opening the PR :) Added some comments just from a quick glance. |
|
(off-topic) @ethanfangg I think the merge queue would be ideal for these 3 PRs + #32450 |
Jay-o-Way
changed the title
|
Is there anything blocking this? |
|
In general looks good, but will revisit this series or PRs on .82 to not interfere with localization for Build right now, since it does change quite some strings. Hope this makes sense. |
Well, I don't have the knowledge that you have. But if you say so. |
Summary of the Pull Request
Split from #32351
Closely linked to #32514 and #32516 and #32450.
PR Checklist
Validation Steps Performed
Build