New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVDAObjects/UIA: forcefully raise value change event for combo boxes that does expose value pattern yet does not raise the said event. re #6337 #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that does expose value pattern yet does not raise the said event. re nvaccess#6337. Some combo boxes does expose value pattern but does not raise value change event. To get around this, selection on its children (items) will be tracked (same trick as combo boxes with no value pattern).
michaelDCurran
approved these changes
May 9, 2017
I think this is causing brokenness in some cases. STR:
NVDA now says "list" and throws an unhandled exception. Pressing NVDA+tab to report the focus also throws an exception. Log fragment:
|
…#6337. Caught by Jamie Teh (NV Access): when searching for items in store, the media type list is sometimes shown, and this may not have the required pattern at all. If this happens, Attribute Error is raised. When handling this, catch this error first, otherwise AttributeError will continue to be raised.
Hi, |
michaelDCurran
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Resolves the following issue:
Suggested what's new entry (bug fix): NVDA will announce selection changes for certain Windows 10 combo boxes.
Thanks.
Fixes #6337