Limit NVDA to running only on at least Windows 7 SP1 or Windows Server 2008 R2 SP1 #7546
Conversation
… Windows Server 2008 R2 SP1
|
Ref #6718 (superseded by this PR). Thanks.
From: Michael Curran [mailto:notifications@github.com]
Sent: Wednesday, August 30, 2017 9:34 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] Limit NVDA to running only on at least Windows 7 SP1 or Windows Server 2008 R2 SP1 (#7546)
Summary of the issue:
It is becoming increasingly harder to maintain support for older Operating Systems while at the same time fixing bugs and adding new features for newer Operating systems. While fixing #7269 <#7269> with pr #7535 <#7535> , support for Windows XP was broken.
Description of how this pull request fixes the issue:
With the merge of this PR, NV Access chooses to drop support of Operating systems older than Windows 7 SP1 or Windows Server 2008 R2 SP1.
See the official news release from NV Access at: https://www.nvaccess.org/post/nvda-2017-4-drops-support-for-older-operating-systems/
Windows 7 SP1 and Windows Server 2008 R2 SP1 were chosen specifically as Microsoft no longer offers mainstream or extended support for XP, Vista, or Windows 7 with no Service Pack. Windows Server 2008 apparently is still in extended support, however we only have 7 active users. The Windows 10 SDK also only supports these Operating Systems at a minimum, and APIs needed in #7535 <#7535> are only supported in Windows 7 and above.
This PR adds code to the start of NVDA that will show a standard Windows dialog alerting the user to the fact their Operating System is too old for this application, if they try to run it on anything less than Windows 7 SP1 or Windows Server 2008 R2 SP1.
NVDA was already displaying this dialog for Windows XP before the latest Service Pack.
This PR by itself deliberately does not introduce any breaking changes a part from the version check and user guide update. Once this is merged, other PRs can be created for such things as upgrading the Windows SDK etc.
Please note: NV Access will continue to offer the NVDA 2017.3 download from its website for those users who cannot switch to a newer Operating System. Similarly, the NV Access update server will keep users of these older Operating Systems at NVDA 2017.3.
Change log entry:
Changes:
* The minimum supported Operating System for NVDA is now Windows 7 with Service Pack 1, or Windows Server 2008 R2 with Service Pack 1.
…_____
You can view, comment on, or merge this pull request online at:
#7546
Commit Summary
* The minimum Operating System NVDA will now run on is Windows 7 SP1 or Windows Server 2008 R2 SP1
* Update the user guide
File Changes
* M source/nvda.pyw <https://github.com/nvaccess/nvda/pull/7546/files#diff-0> (2)
* M source/winVersion.py <https://github.com/nvaccess/nvda/pull/7546/files#diff-1> (18)
* M user_docs/en/userGuide.t2t <https://github.com/nvaccess/nvda/pull/7546/files#diff-2> (10)
Patch Links:
* https://github.com/nvaccess/nvda/pull/7546.patch
* https://github.com/nvaccess/nvda/pull/7546.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#7546> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkC0sK9VielkidUS0jloyEAbkk9Yhks5sdjfJgaJpZM4PISl8> .
|
|
Looking at the launcher code, I noticed that it doesn't have windows version restrictions. Is this intentional? |
|
The main reason for placing the code in nvda.pyw was to also cover
unpacked portable copies.
We could also add it to the launcher as well, which would cut down the
pointless time of unpacking, however that NSIS code is very tricky and
will need to be tested thoroughly if we do. This pr at least ensures
that the user will not run an unstable NVDA.
|
|
If you want me to test the run stopper code on xp, let me know and I'll test
a download direct from the page as a person might do unaware of the
decision.
As I say, for me as long as the Outlook express app module still works in
7,I'm going to be happy!
I don't want to see code removed that might impact on running legacy
programs on newer windows versions where this is possible.
Care needs to be taken when removing such routines in case undesired
effects occur.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
|
user_docs/en/userGuide.t2t
Outdated
|
|
||
| - For Windows 7, NVDA requires Service Pack 1 or higher. | ||
| - For Windows Server 2008 R2, NVDA requires Service Pack 1 or higher. | ||
|
|
There was a problem hiding this comment.
nit: Having a blank line before and after a sub-list is inconsistent with the rest of the User Guide. Also, the other sub-lists are indented with one space rather than two.
|
We will be merging this to master early as this finalizes the dropping of support for older Operating systems, allowing all new branches to carry this change. The change itself is very small with low risk. |
|
"It is becoming increasingly harder to maintain support for older Operating Systems while at the same time fixing bugs and adding new features for newer Operating systems." i searched about |
Summary of the issue:
It is becoming increasingly harder to maintain support for older Operating Systems while at the same time fixing bugs and adding new features for newer Operating systems. While fixing #7269 with pr #7535, support for Windows XP was broken.
Description of how this pull request fixes the issue:
With the merge of this PR, NV Access chooses to drop support of Operating systems older than Windows 7 SP1 or Windows Server 2008 R2 SP1.
See the official news release from NV Access at: https://www.nvaccess.org/post/nvda-2017-4-drops-support-for-older-operating-systems/
Windows 7 SP1 and Windows Server 2008 R2 SP1 were chosen specifically as Microsoft no longer offers mainstream or extended support for XP, Vista, or Windows 7 with no Service Pack. Windows Server 2008 apparently is still in extended support, however we only have 7 active users. The Windows 10 SDK also only supports these Operating Systems at a minimum, and APIs needed in #7535 are only supported in Windows 7 and above.
This PR adds code to the start of NVDA that will show a standard Windows dialog alerting the user to the fact their Operating System is too old for this application, if they try to run it on anything less than Windows 7 SP1 or Windows Server 2008 R2 SP1.
NVDA was already displaying this dialog for Windows XP before the latest Service Pack.
This PR by itself deliberately does not introduce any breaking changes a part from the version check and user guide update. Once this is merged, other PRs can be created for such things as upgrading the Windows SDK etc.
Please note: NV Access will continue to offer the NVDA 2017.3 download from its website for those users who cannot switch to a newer Operating System. Similarly, the NV Access update server will keep users of these older Operating Systems at NVDA 2017.3.
Change log entry:
Changes: