Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's new: issue number edits, recognize Windows 10 RS5/Server 2019 #8540

Merged
merged 7 commits into from Jul 31, 2018

Conversation

josephsl
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

Edits to what's new document for NVDA 2018.3.

Description of how this pull request fixes the issue:

Changed issue numbers where they were previously pointing to pull requests. In case of braille tables, the two entries have been combined into one, as well as capitalized table names. Also, recognize the fact that Windows 10 RS5 has a server variant: Windows Server 2019.

Testing performed:

Compiled docs from source with no issues.

Known issues with pull request:

None

Change log entry:

None

Thanks.

Changed issue numbers where they were previously pointing to pull requests. In case of braille tables, the two entries have been combined into one. Also, recognize the fact that Windows 10 RS5 also has a server variant: Windows Server 2019.
michaelDCurran
michaelDCurran previously approved these changes Jul 23, 2018
Copy link
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, could you check that every entry starts with a capital letter? We should actually unit test this somehow.

Furthermore, it might be good to add an entry for 2018.2.1, not that it's super important, but it will make it easier to find out what this release was for in the future.

- custom roles via the aria-roledescription attribute are now supported in all web browsers. (#8449)
- New braille table: Swedish 8 dot computer braille. (#8227)
- added czech eight dots, central kurdish, esperanto and hungarian braille tables. (#8446)
- custom roles via the aria-roledescription attribute are now supported in all web browsers. (#8448)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this line to start with an uppercase c

- New braille table: Swedish 8 dot computer braille. (#8227)
- added czech eight dots, central kurdish, esperanto and hungarian braille tables. (#8446)
- custom roles via the aria-roledescription attribute are now supported in all web browsers. (#8448)
- New braille table: Czech 8 dot, Central Kurdish, Esperanto, Hungarian, Swedish 8 dot computer braille. (#8226, #8437)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table>tables

- NVDA will recognize more dialogs in Windows 10 and other modern applications. (#7473)
- On windows 10 rs5 and above, NVDA no longer fails to track the system focus when an application freezes or floods the system with events. (#8539)
- NVDA will recognize more dialogs in Windows 10 and other modern applications. (#8405)
- On Windows 10 rs5 and Server 2019 and above, NVDA no longer fails to track the system focus when an application freezes or floods the system with events. (#7345, #8535)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should refer to rs5 as the Windows 10 Oktober 2018 update, which will most likely be the name for that update.

@josephsl
Copy link
Collaborator Author

josephsl commented Jul 23, 2018 via email

Requested by @LeonarddeR (Babbage):
* Windows 10 RS5: October 2018 Update
* Capitalized more entries.
* Added an explanatory text about 2018.2.1 release.
michaelDCurran
michaelDCurran previously approved these changes Jul 31, 2018
@michaelDCurran
Copy link
Member

@LeonarddeR are you happy with this now?

LeonarddeR
LeonarddeR previously approved these changes Jul 31, 2018
Copy link
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead after fixing just one mistake

- New braille table: Swedish 8 dot computer braille. (#8227)
- added czech eight dots, central kurdish, esperanto and hungarian braille tables. (#8446)
- Custom roles via the aria-roledescription attribute are now supported in all web browsers. (#8448)
- New braille table: Czech 8 dot, Central Kurdish, Esperanto, Hungarian, Swedish 8 dot computer braille. (#8226, #8437)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table>tables

@josephsl josephsl dismissed stale reviews from LeonarddeR and michaelDCurran via 6027c59 July 31, 2018 05:08
@josephsl
Copy link
Collaborator Author

josephsl commented Jul 31, 2018 via email

@michaelDCurran michaelDCurran merged commit 14b74d3 into nvaccess:master Jul 31, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 31, 2018
@josephsl josephsl deleted the docs18.3 branch July 19, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants