Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #1851 "MON-3538: Promote MetricsServer FeatureGate to GA" #1863

Merged
merged 1 commit into from Apr 22, 2024
Merged

Revert #1851 "MON-3538: Promote MetricsServer FeatureGate to GA" #1863

merged 1 commit into from Apr 22, 2024

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Apr 21, 2024

Reverts #1851 ; tracked by https://issues.redhat.com/browse/TRT-1608

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to monitoring pathological event failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

CC: @slashpai

PR created by Revertomatic™️

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2024 •
edited by openshift-ci bot

@neisw: This pull request references MON-3538 which is a valid jira issue.

In response to this:

Reverts #1851 ; tracked by https://issues.redhat.com/browse/TRT-1608

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to monitoring pathological event failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

CC: @slashpai

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

Hello @neisw! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2024
@openshift-ci openshift-ci bot requested review from bparees and mfojtik April 21, 2024 13:23
@neisw
Copy link
Contributor Author

neisw commented Apr 21, 2024

/payload 4.16 nightly blocking

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

@neisw: trigger 8 job(s) of type blocking for the nightly release of OCP 4.16

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/92102f10-ffe2-11ee-8726-0f752ce5bbb0-0

@neisw
Copy link
Contributor Author

neisw commented Apr 21, 2024

/hold
opened for testing, wait for validation

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2024
@slashpai
Copy link
Member

Let's revert we can add the fix https://issues.redhat.com/browse/OCPBUGS-32510 and test the payload jobs again while un-reverting

cc: @jan--f

@rexagod rexagod mentioned this pull request Apr 22, 2024
Merged
@neisw
Copy link
Contributor Author

neisw commented Apr 22, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@dgoodwin
Copy link
Contributor

/lgtm

@dgoodwin
Copy link
Contributor

/label approved

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2024
@slashpai
Copy link
Member

/lgtm

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@deads2k
Copy link
Contributor

deads2k commented Apr 22, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dgoodwin, neisw, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a8b3ba9 into openshift:master Apr 22, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202404221711.p0.ga8b3ba9.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

@slashpai slashpai mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dgoodwin dgoodwin

@slashpai slashpai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@neisw @openshift-ci-robot @slashpai @dgoodwin @deads2k @openshift-bot